Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release 1.0.90 regression from 1.0.89: wit-bindgen panicking #483

Closed
pchickey opened this issue Nov 21, 2024 · 5 comments · Fixed by #484
Closed

release 1.0.90 regression from 1.0.89: wit-bindgen panicking #483

pchickey opened this issue Nov 21, 2024 · 5 comments · Fixed by #484

Comments

@pchickey
Copy link

pchickey commented Nov 21, 2024

wit-bindgen takes a dependency on syn = { version = "2.0", features = ["printing"] }.

In projects with unlocked deps, this macro is panicking when compiled with latest patch release of syn, and with it proc-macro2 1.0.90. It shows the message
= help: message: compiler/fallback mismatch #949 which I believe is coming from src/wrapper.rs:48 in this package, and therefore set_span.

For an example of the failure https://github.com/yoshuawuyts/wstd/actions/runs/11946511007/job/33301083203?pr=22#step:4:535

Earlier today same packages built with proc-macro2 1.0.89 https://github.com/yoshuawuyts/wstd/actions/runs/11940671307/job/33283840092#step:4:151

Unfortunately I don't understand the internals of this crate enough to diagnose further. Is this my issue, or a bug in the latest proc-macro2 release?

@sehz
Copy link

sehz commented Nov 21, 2024

All our project builds are now failing due to this. We rely on wit-bindgen.

@sehz
Copy link

sehz commented Nov 21, 2024

@dtolnay, is possible to revert changes and do another release?

@dtolnay
Copy link
Owner

dtolnay commented Nov 21, 2024

This is fixed in 1.0.91.

@sehz
Copy link

sehz commented Nov 21, 2024

Confirm fixed works. Thanks!

@pchickey
Copy link
Author

Thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants