Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split cxx runtime and build components #167

Merged
merged 2 commits into from
Apr 30, 2020
Merged

Split cxx runtime and build components #167

merged 2 commits into from
Apr 30, 2020

Conversation

dtolnay
Copy link
Owner

@dtolnay dtolnay commented Apr 30, 2020

This PR moves out the build-related parts of the cxx crate to a separate cxx-build crate. The two would now be used as:

  [dependencies]
  cxx = "0.3"

  [build-dependencies]
- cxx = "0.3"
+ cxx-build = "0.3"

Closes #144.

dtolnay
dtolnay commented Apr 30, 2020
View reviewed changes
Copy link
Owner Author

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This exposes what I think is a Buck bug so I am disabling the Buck CI until I get a chance to look closer.

@dtolnay dtolnay merged commit b4714a7 into master Apr 30, 2020
@dtolnay dtolnay deleted the split branch April 30, 2020 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Split cxx crate into runtime and build.rs components
1 participant
@dtolnay