Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable backtrace test on miri #246

Closed
dtolnay opened this issue Jul 24, 2022 · 5 comments
Closed

Re-enable backtrace test on miri #246

dtolnay opened this issue Jul 24, 2022 · 5 comments

Comments

@dtolnay
Copy link
Owner

dtolnay commented Jul 24, 2022

8d25d6b will probably be possible to revert shortly.

rust-lang/miri#2431
rust-lang/miri#2436

@RalfJung
Copy link
Contributor

What exactly does the build.rs probe do? I see it does an --emit=metadata call; if it expects any actual files to be created, then rust-lang/miri#2436 is not enough. OTOH if rust-lang/miri#2436 is enough then it should fix using miri+anyhow in cross-interpretation for a foreign target (which was likely broken before... or, looking at the code it doesn't check TARGET so I guess it doesn't work for cross-compilation anyway?).

@dtolnay
Copy link
Owner Author

dtolnay commented Jul 24, 2022

It does not need any actual files written out by the rustc invocation. It's just looking for a success or fail exit code from a "check"-style build.

@RalfJung
Copy link
Contributor

Okay, yeah that is like what autocfg does so it should work with that PR (and we'll have it on CI).

You might want to check autocfg's TARGET handling though, otherwise I am not sure what this does is correct for cross-compilation. The probe seems to always test the host, not the target.

@RalfJung
Copy link
Contributor

Should be fixed in the latest nightly.

@dtolnay
Copy link
Owner Author

dtolnay commented Jul 26, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants