-
-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable backtrace test on miri #246
Comments
What exactly does the build.rs probe do? I see it does an |
It does not need any actual files written out by the rustc invocation. It's just looking for a success or fail exit code from a "check"-style build. |
Okay, yeah that is like what autocfg does so it should work with that PR (and we'll have it on CI). You might want to check autocfg's TARGET handling though, otherwise I am not sure what this does is correct for cross-compilation. The probe seems to always test the host, not the target. |
Should be fixed in the latest nightly. |
Thanks! |
8d25d6b will probably be possible to revert shortly.
rust-lang/miri#2431
rust-lang/miri#2436
The text was updated successfully, but these errors were encountered: