* add the possibility to use ${session.user} for variable expansion in r...

[strima]

...emote urls

we needed this, since some values in the generated select boxes shall only be shown to certain users/groups

• should be what in issue feature request: add the variable ${job.user.name} to the Option model provider #494 was referenced to
• build was successful
• tests also

[gschueler]

Thanks for the pull request. I think I would change "session.user" to "job.username", just so it is more consistent with the variables available at Job execution time.

[strima]

You're welcome.

First: Shall it be job.username or job.user.name so that you could also do something like job.user.mail, job.user.surname, ... ?

Second: Since i'm fairly new to github workflow, shall i do the change based on my current version or should i rebase on dev tree, and then send a new pull request or can i extend this request ?

mfg

[gschueler]

job.user.name sounds good.

The best workflow is to put the changes on a separate branch and pull request from that. Then if necessary you can rebase on our dev branch and force push to your separate branch again, and the pull request will reflect that.

For this pull request, feel free to rebase or not. As long as you push to the same branch you sent the pull request from, the changes will show up here I believe.

[gschueler]

merged in and made the job.user.name change in #494