Update sample scripts in plugin docs for best practices conformance #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use `printf %q` to quote arguments to survive expansion by the remote shell (started by ssh) unharmed. - Quote all local parameter expansions to prevent contents from being word-split and glob-expanded. - Replace use of external tool `basename` with a parameter expansion (shell builtin; no fork/wait overhead) - Do not use `exec` on a command for which additional commands are expected to be run in the same shell. (`exec` replaces the current process, and does not return). - Move assignments from `$1` and `shift`s onto the same line for easier reading. - `exit $?` is redundant; the default behavior of `exit` is to honor `$?`.
ahonor
added a commit
that referenced
this pull request
Feb 11, 2013
Update sample scripts in plugin docs for best practices conformance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
printf %qto quote arguments to survive expansion by the remoteshell (started by ssh) unharmed.
word-split and glob-expanded.
basenamewith a parameter expansion(shell builtin; no fork/wait overhead)
execon a command for which additional commands areexpected to be run in the same shell. (
execreplaces the currentprocess, and does not return).
$1andshifts onto the same line for easierreading.
exit $?is redundant; the default behavior ofexitis to honor$?.