BakaTsuki - Content list (table of contents) #27

typhoon71 · 2016-06-28T06:39:36Z

Small fix needed.
If the table of content is hidden while viewing a BakaTsuki novel, the plugin will show a page like this.

Can an option be added to remove it completely if it's hidden?
And maybe another option to automaticlly "show" it instead?

belldandu · 2016-06-28T12:18:36Z

Toc is actually stripped from the novel

WebToEpub/plugin/js/parsers/BakaTsukiParser.js

Line 101 in 7f3bbcb

// discard table of contents (will generate one from tags later)

The problem here is that the class changes to "toc tochidden" when you click hide. Which causes it to remain.

simple fix would be to compare the id instead of the class. @dteviot

belldandu · 2016-06-29T17:25:39Z

@typhoon71 can this be closed?

typhoon71 · 2016-06-29T17:52:31Z

Uhm, I don't see any difference from 0.0.0.7? Did the "simple fix" above get implemented?
If it won't, I'm fine closing this anyway because I just need to not hide the toc on the novel page.

dteviot · 2016-06-29T19:00:45Z

@typhoon71
It should have been.
The code change has been committed.
d401703,
lines 119 - 120.
That said, fix looked so simple I did not test it.
And it's always possible I sent the wrong file to Google.

On Thu, Jun 30, 2016 at 5:52 AM, typhoon71 [email protected] wrote:

Uhm, I don't see any difference from 0.0.0.7? Did the "simple fix" above
get implemented?
If it won't, I'm fine closing this anyway because I just need to not hide
the toc on the novel page.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#27 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AE6w2YJOgugVgKxN5OkbsIVSHIQgEqHGks5qQrDfgaJpZM4I_yW2
.

typhoon71 · 2016-06-29T20:23:47Z

OK, I'm testing v0009 from sonako with firefox (oogle still on v0008).
I get this with every novel I try.

Happens with "Set Cover" both selected or unselected.

dteviot · 2016-06-29T21:28:12Z

@typhoon71
I will have to look into this tonight. Currently busy at my day job.

I'll point out v0.0.0.9 is just because I bump the version number
immediately after a release. Code wise, 0.0.0.9 from sonako branch is same
as the 0.0.0.8 release.

On Thu, Jun 30, 2016 at 8:23 AM, typhoon71 [email protected] wrote:

OK, I'm testing v0009 from sonako with firefox (oogle still on v0008).
I get this with every novel I try.

[image: ufff]
https://cloud.githubusercontent.com/assets/1866248/16467504/f0577c64-3e47-11e6-83d9-3108e7eac1eb.png

Happens with "Set Cover" both selected or unselected.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#27 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AE6w2SLvdALQMIbZVaPdNus9F-Di-jZsks5qQtRTgaJpZM4I_yW2
.

typhoon71 · 2016-06-29T21:53:31Z

np, do it when you can/want, I'm already happy I won't have to do the html -> epub (or pdf) by hand...

belldandu · 2016-06-29T22:29:10Z

@typhoon71 That fetch of url error happens because the server returns a response other then 200.

@dteviot this ties into #13

We really also need to put in #14 an option for retrying if a server returns something other than 404 when it doesn't return 200.

typhoon71 · 2016-06-30T06:29:22Z

I don't know wh ythat error happens, and it's strange because I was able to fetch the whole thing before without issues. It seems it's still avail to me?

dteviot · 2016-06-30T19:19:55Z

@typhoon71 Belldandu is saying that the server is returning some response other than 200 (success), I'm going to guess you were getting a 50x series network error (unable to get file, usually due to some problem with the CDN.) Under that case, the generator just gives up. Obviously, better error reporting is required.

typhoon71 · 2016-06-30T20:08:00Z

But it should give success, if I just browse to the images I can open them... so the CDN should be working.
I mean, in this case I would expect a 200 -only-, nothing else.

dteviot · 2016-06-30T20:33:04Z

@typhoon71 Stupid questions,

is it only Firefox that has problems, or does the Crome version have same problem?
Does it work for older Firefox versions? If so, which ones?

belldandu · 2016-06-30T20:55:00Z

@typhoon71 Another few stupid questions,

does this only happen on this specific page?
if not, what other pages does this happen on?

dteviot · 2016-07-01T05:26:53Z

Interesting, on Firefox, the images download and the epub is built, but the xhtml files are not correct.
The style information is visible in an epub viewer. Will investigate further, later.

typhoon71 · 2016-07-01T07:07:05Z

Not a stupid question at all, didn't think of checking that.
I manually installed the plugin in chrome (to be 100% sure it's the same as in firefox) and it packs the epub.
There are 2 buts: the plugin manager windows has some errors after loading it:

and sigil sometime complains about malformed html on some novels.
https://baka-tsuki.org/project/index.php?title=This_title_is_too_long%21%3AVolume2 is affected, for example.

Since I started using this plugin I didn't update firefox, it's always been 47.0; I started having issues with the plugin 0.0.0.8, before it worked (I mean, it didn't just trow that error and stop).

To answer the last question, the problem with firefox happens on any page, it's not limited to the one I linked you.

typhoon71 · 2016-07-01T07:17:37Z

Small update, happens with Firefox 47.0.1 too (just updated).
I see minimum_firefox_version is set to 48... which is still beta... it would be sensible to set it to 47 instead.

belldandu · 2016-07-01T12:51:33Z

The reason the minimum firefox version is 48 is because its using WebExtensions which is only supported by BETA/Aurora Firefox @typhoon71

@dteviot The reason he is getting these issues is more then likely because he is trying to use the extension on an unsupported version.

Since i have Aurora installed i will investigate this later and put whether or not this is reproducible in Aurora.

typhoon71 · 2016-07-01T13:32:14Z

I understand why you're using WebExtensions, but wouldn't it make sense to wait to intruduce them till Firefox 48 is released? Even keeping < Firefox 48 would be nice, after all there's the matter of what will happen when Mozilla will kill XUL & friends; some may decide to stay on older releases to wait and see what happens to the extensions... (a bloodbath I suppose).
This from a Firefox user standpoint; from a chrome user standpoint, it's irrelevant.

belldandu · 2016-07-01T13:46:26Z

The reason we have not waited is for people to test it on the Aurora release so that we can scratch away any bugs before it becomes a stable version of firefox.

belldandu · 2016-07-01T13:50:14Z

Also as for those manifest key errors thats because the firefox manifest and chrome manifest are one file so chrome doesn't know what to do with the keys. You can safely ignore those errors.

typhoon71 · 2016-07-01T13:59:53Z

OK, so I guess that I'll have to use chrome to make epubs, since the plugin now doesn't work on Firefox < 48...
I won't ask to not use WebExtensions, I just hope that Firefox 48 doesn't break anything...

typhoon71 · 2016-07-01T14:10:57Z

my bad, wrong button.

belldandu · 2016-07-01T14:13:08Z

Just Tested on https://baka-tsuki.org/project/index.php?title=CubexCursedxCurious:Volume1 seems to work fine. Although i do get your error message on https://baka-tsuki.org/project/index.php?title=CubexCursedxCurious But i think its obvious why.

belldandu · 2016-07-01T14:17:15Z

see #37

typhoon71 · 2016-07-01T14:35:00Z

About the issue on firefox: I suppose it works in aurora, but I'll wait for ffox 48 to be released before testing.

About Sigil complaints, I get none on C3 volume 1. Maybe in some cases it happens, in some it doesn't.
Regarding "https://baka-tsuki.org/project/index.php?title=This_title_is_too_long%21%3AVolume2", the malformed html seems to be "0005_Afterword.xhtml", but I don't see anything strange opening the epub with calibre or even sumatra.

dteviot · 2016-08-21T02:48:49Z

As far as I can tell, all issues raised here are either fixed or documented as part of other issues. So closing.

belldandu mentioned this issue Jun 28, 2016

Remove blank elements #30

Merged

dteviot mentioned this issue Jun 30, 2016

Failure to fetch image stops fetch of rest of images #13

Closed

typhoon71 closed this as completed Jul 1, 2016

typhoon71 reopened this Jul 1, 2016

belldandu added the Type: Bug label Jul 3, 2016

belldandu self-assigned this Jul 3, 2016

typhoon71 mentioned this issue Jul 7, 2016

Firefox - Keep compatibility with non-WebExtension Browser #42

Closed

belldandu added the Priority: Low label Jul 12, 2016

dteviot closed this as completed Aug 21, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

BakaTsuki - Content list (table of contents) #27

BakaTsuki - Content list (table of contents) #27

typhoon71 commented Jun 28, 2016

belldandu commented Jun 28, 2016

belldandu commented Jun 29, 2016

typhoon71 commented Jun 29, 2016

dteviot commented Jun 29, 2016

typhoon71 commented Jun 29, 2016

dteviot commented Jun 29, 2016

typhoon71 commented Jun 29, 2016

belldandu commented Jun 29, 2016

typhoon71 commented Jun 30, 2016

dteviot commented Jun 30, 2016

typhoon71 commented Jun 30, 2016

dteviot commented Jun 30, 2016

belldandu commented Jun 30, 2016 •

edited

Loading

dteviot commented Jul 1, 2016

typhoon71 commented Jul 1, 2016

typhoon71 commented Jul 1, 2016

belldandu commented Jul 1, 2016 •

edited

Loading

typhoon71 commented Jul 1, 2016

belldandu commented Jul 1, 2016

belldandu commented Jul 1, 2016

typhoon71 commented Jul 1, 2016

typhoon71 commented Jul 1, 2016

belldandu commented Jul 1, 2016 •

edited

Loading

belldandu commented Jul 1, 2016

typhoon71 commented Jul 1, 2016

dteviot commented Aug 21, 2016

BakaTsuki - Content list (table of contents) #27

BakaTsuki - Content list (table of contents) #27

Comments

typhoon71 commented Jun 28, 2016

belldandu commented Jun 28, 2016

belldandu commented Jun 29, 2016

typhoon71 commented Jun 29, 2016

dteviot commented Jun 29, 2016

typhoon71 commented Jun 29, 2016

dteviot commented Jun 29, 2016

typhoon71 commented Jun 29, 2016

belldandu commented Jun 29, 2016

typhoon71 commented Jun 30, 2016

dteviot commented Jun 30, 2016

typhoon71 commented Jun 30, 2016

dteviot commented Jun 30, 2016

belldandu commented Jun 30, 2016 • edited Loading

dteviot commented Jul 1, 2016

typhoon71 commented Jul 1, 2016

typhoon71 commented Jul 1, 2016

belldandu commented Jul 1, 2016 • edited Loading

typhoon71 commented Jul 1, 2016

belldandu commented Jul 1, 2016

belldandu commented Jul 1, 2016

typhoon71 commented Jul 1, 2016

typhoon71 commented Jul 1, 2016

belldandu commented Jul 1, 2016 • edited Loading

belldandu commented Jul 1, 2016

typhoon71 commented Jul 1, 2016

dteviot commented Aug 21, 2016

belldandu commented Jun 30, 2016 •

edited

Loading

belldandu commented Jul 1, 2016 •

edited

Loading

belldandu commented Jul 1, 2016 •

edited

Loading