-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Advanced Options button #14
Comments
Following have been implemented
|
Updated this issue to use task lists @dteviot https://github.com/blog/1375-task-lists-in-gfm-issues-pulls-comments |
Need to move Cover from URL: to advanced options btw as they havent been moved in 0.0.0.11 |
@typhoon71 @dreamer2908@toshiya44 added UserPreferences saved to local storage.
|
UserPreferences works on chrome, well done. I noticed that I get a white page here: "https://www.baka-tsuki.org/project/index.php?title=Chronicle_Legion:Volume_1"; also, the tab with nation names is cut in two (brutally), with a cut in the middle of a line. Nothing else spotted. |
I wanted to get the preferences in, so that you can try tweaking the |
Oh, new options to play with, nice. Btw: now I have no issue with "https://baka-tsuki.org/project/index.php?title=The_Unexplored_Summon_Blood_Sign:Volume1&printable=yes", which was the one I had issues before (white pages and cut images). I'm curious on how tabs can be treated when they don't fit on a single page... |
Tested the new options and features, I don't see any issue so far. Thanks for the "Fetch highest resolution image" option. |
Me too. I didn't think I'd made any changes there. Another item to add to my ToDo list.
Thank you.
Actually, it's been fetching the highest resolution image for some time. (That was the second change belldandu made to the code.) I prefer the lower res images. Quicker to download, and significantly smaller epub file. The change was for me, it's really a "fetch reduced resolution images", by turning it off. :) |
Yup, low res images looks fine when I'm reading on phone and doesn't take up too much space. It's great :D |
@toshiya44 @typhoon71 |
I'll test it tomorrow, but I can make some suggestions.
As of now, I use to do lists of customized links + chapter names... and paste into the urls fetched by web to epub: so NO, don't scrap this idea! It's a good one, really. |
I think it's best left as a comment in a specific file or in a text file inside the epub. Readers don't need to see this.
Will it be able to update an epub as well? For example, redownloading the chapters in an epub based on the list of URLs? |
@typhoon71 @toshiya44 I've created #145 specifically for the Automatically Update EPUB feature. What I'd like to know is if you think there's any value in the user being able to see the list of fetched URLs (chapters and images.) Toshiya has explicitly said He doesn't think there's value in readers seeing the information, and I think typhoon implies it with his comment
i.e. This information should not be visible to user. |
Good, the extra data being hidden is good. |
Looks like I should use <source> metadata elements for associating content with original URLs. <element name="source">
<ref name="OPF20.optional-id-attribute"/>
<ref name="OPF20.optional-xml-lang-attribute"/>
<ref name="DC.metadata-common-content"/>
</element> |
Refer: #14 Use <dc:source> elements in content.opf to record where each item in packed EPUB came from. Note, because of requirement that "id" attributes must be unique I've prefixed the IDs with "id.".
Source URL for each item recorded in |
(note for self)
Put "Advanced Options" button to right of progress bar.
Button is only visible if Parser advertises that it has advanced options.
If clicked, additional options are put on dialog.
e.g.
Add List of source URLs to end of ePUB. (default off)No need for this to be visible to most readers. Instead is encoded in <source> elements in contents.opf.Setting needed for retrying on non 404 error pages (default off) and allowing setting of max retries (default 3)Proved too difficult to implement. Instead, tell user there was problem and give option to retryAlso note
Also, need to preserve settings when generator updates itself from Chrome store.Seems to do this automatically.The text was updated successfully, but these errors were encountered: