Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub actions workflows to switch from node 16 to node 20 #510

Closed
1 of 20 tasks
lisagoodrich opened this issue Jan 24, 2024 · 0 comments · Fixed by #512
Closed
1 of 20 tasks

Update GitHub actions workflows to switch from node 16 to node 20 #510

lisagoodrich opened this issue Jan 24, 2024 · 0 comments · Fixed by #512
Labels
component: repository maintenance Repository maintenance issue priority: medium Medium Priority requestor: METplus Team METplus Development Team type: task An actionable item of work

Comments

@lisagoodrich
Copy link
Contributor

lisagoodrich commented Jan 24, 2024

Describe the Task

As of January 24, 2024, the following warning messages began appearing on the MET GitHub action workflow runs:

[Build Documentation](https://github.com/dtcenter/MET/actions/runs/7642630271/job/20822701483)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-python@v4, actions/upload-artifact@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Our call to actions/checkout@v3 triggers this warning message, as do other similar actions. Recommend upgrading action version numbers as needed to move past this warning. Make these change in both the develop and main_v11.1 branches.

Can use the following commands to update:

cd .github/workflows
for file in `ls *.yml`; do 
  cat $file | \
  sed 's%actions/checkout@v3%actions/checkout@v4%g' | \
  sed 's%actions/upload-artifact@v3%actions/upload-artifact@v4%g' | \
  sed 's%actions/download-artifact@v3%actions/download-artifact@v4%g' | \
  sed 's%actions/setup-python@v4%actions/setup-python@v5%g' | \
  sed 's%actions/github-script@v6%actions/github-script@v7%g' > tmp;
  mv tmp $file;
done

To also capture the yaml files run this:

cd .github/workflows
for file in `ls *.yaml`; do 
  cat $file | \
  sed 's%actions/checkout@v3%actions/checkout@v4%g' | \
  sed 's%actions/upload-artifact@v3%actions/upload-artifact@v4%g' | \
  sed 's%actions/download-artifact@v3%actions/download-artifact@v4%g' | \
  sed 's%actions/setup-python@v4%actions/setup-python@v5%g' | \
  sed 's%actions/github-script@v6%actions/github-script@v7%g' > tmp;
  mv tmp $file;
done

Time Estimate

2 hours.

Sub-Issues

This is being done across all MET components. Here is a link to the METplus issue #2796

Relevant Deadlines

Funding Source

2702691 JNT DTC NSF BASE FUN…
2784543 NOAA R2O METp SW2
2799991 Met Office METplus S…

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED CYCLE ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Task Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@lisagoodrich lisagoodrich added type: task An actionable item of work priority: medium Medium Priority requestor: METplus Team METplus Development Team component: repository maintenance Repository maintenance issue labels Jan 24, 2024
@lisagoodrich lisagoodrich added this to the METviewer-5.1.0 milestone Jan 24, 2024
This was linked to pull requests Jan 29, 2024
@github-project-automation github-project-automation bot moved this from 🔖 Ready to ✅ Done in Coordinated METplus-5.1 Support Feb 2, 2024
@TatianaBurek TatianaBurek removed a link to a pull request Feb 8, 2024
13 tasks
@hankenstein2 hankenstein2 moved this from 🔖 Ready to 📋 Backlog in METplus-Analysis-6.0.0 Development Apr 3, 2024
@bikegeek bikegeek moved this from 📋 Backlog to ✅ Done in METplus-Analysis-6.0.0 Development Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: repository maintenance Repository maintenance issue priority: medium Medium Priority requestor: METplus Team METplus Development Team type: task An actionable item of work
Projects
Status: 🏁 Done
Development

Successfully merging a pull request may close this issue.

2 participants