Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Testing
A dedication for all of the User's Guides has been added to honor the passing and contributions of Randy Bullock, Venita Hagerty, and Tara Jensen. New links were also added so readers could get more information on each individual.
I created two branches:
One branch off of the METplus main_v6.0 branch called
feature_main_metplus_2780_dedication
One branch off of the METplus develop branch called
feature_metplus_2780_dedication
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Please review the content for clarity and typos.
Then please copy and paste these directly into the main_vX.Y and develop branches for all repos, bypassing any PRs because we've already approved it in one. We decided that this process made the most sense to avoid extra steps simply due to process.
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
Do these changes include sufficient testing updates? [Yes]
Will this PR result in changes to the test suite? [No]
If yes, describe the new output and/or changes to the existing output:
Do these changes introduce new SonarQube findings? [No]
If yes, please describe:
Please complete this pull request review by [12/13/24].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s) and Development issue
Select: Milestone as the version that will include these changes
Select: Coordinated METplus-X.Y Support project for bugfix releases or METplus-Wrappers-X.Y.Z Development project for official releases