Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature metplus 2780 dedication #2819

Merged
merged 5 commits into from
Dec 12, 2024
Merged

Conversation

lisagoodrich
Copy link
Contributor

Pull Request Testing

  • Describe testing already performed for these changes:

    A dedication for all of the User's Guides has been added to honor the passing and contributions of Randy Bullock, Venita Hagerty, and Tara Jensen. New links were also added so readers could get more information on each individual.

I created two branches:
One branch off of the METplus main_v6.0 branch called feature_main_metplus_2780_dedication
One branch off of the METplus develop branch called feature_metplus_2780_dedication

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    Please review the content for clarity and typos.
    Then please copy and paste these directly into the main_vX.Y and develop branches for all repos, bypassing any PRs because we've already approved it in one. We decided that this process made the most sense to avoid extra steps simply due to process.

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Do these changes introduce new SonarQube findings? [No]

    If yes, please describe:

  • Please complete this pull request review by [12/13/24].

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • For any new datasets, an entry to the METplus Verification Datasets Guide.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or METplus-Wrappers-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@lisagoodrich lisagoodrich added this to the METplus-6.0.0 milestone Dec 10, 2024
@lisagoodrich lisagoodrich linked an issue Dec 10, 2024 that may be closed by this pull request
24 tasks
Copy link
Collaborator

@jprestop jprestop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for your work on this @lisagoodrich and @michelleharrold. I approve this request. I will copy and paste these directly into the main_vX.Y and develop branches for all repos, bypassing any PRs because we've already approved it in this one. We decided that this process made the most sense to avoid extra steps simply due to process.

@jprestop jprestop merged commit 6a75f43 into develop Dec 12, 2024
3 checks passed
@jprestop jprestop deleted the feature_metplus_2780_dedication branch December 12, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏁 Done
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

Add a dedication to all of the User's Guides
2 participants