Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix #1706 fix PhaseDiagram use case to avoid writing into INPUT_BASE #1709

Merged
merged 3 commits into from
Jul 26, 2022

Conversation

georgemccabe
Copy link
Collaborator

Corresponding PR for develop is #1708

Pull Request Testing

  • Describe testing already performed for these changes:

Ran PhaseDiagram use case that previously failed locally if INPUT_BASE is not writable by the user and confirmed that it now works.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

Confirm that changes look OK and that all automated tests pass except the diff for the new output file that is now written by the use case in OUTPUT_BASE

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [Yes]

    If yes, describe the new output and/or changes to the existing output:

    The time_list_lead000.txt may flag a difference since it is now written into OUTPUT_BASE

  • Please complete this pull request review by 7/26/2022.

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Linked issues with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@georgemccabe georgemccabe changed the title per #1706, create output directory if it does not already exist becau… bugfix #1706 fix PhaseDiagram use case to avoid writing into INPUT_BASE Jul 25, 2022
Copy link
Contributor

@CPKalb CPKalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and ran as expected

@georgemccabe georgemccabe merged commit 2dc00db into main_v4.1 Jul 26, 2022
@georgemccabe georgemccabe deleted the bugfix_main_v4.1_1706_write_to_input_base branch July 26, 2022 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Bugfix: Phase Diagram use case writes all output into OUTPUT_BASE instead of INPUT_BASE
2 participants