-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix #1706 fix PhaseDiagram use case to avoid writing into INPUT_BASE #1708
Merged
georgemccabe
merged 2 commits into
develop
from
bugfix_develop_1706_write_to_input_base
Jul 26, 2022
Merged
bugfix #1706 fix PhaseDiagram use case to avoid writing into INPUT_BASE #1708
georgemccabe
merged 2 commits into
develop
from
bugfix_develop_1706_write_to_input_base
Jul 26, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se the file i/o logic will fail if the directory does not exist
…ASE instead of INPUT_BASE and changed input directory path to find the correct file in the INPUT_BASE
Closed
23 tasks
14 tasks
CPKalb
reviewed
Jul 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works as expected
georgemccabe
pushed a commit
that referenced
this pull request
Apr 6, 2023
Co-authored-by: Julie Prestopnik <[email protected]> Co-authored-by: johnhg <[email protected]> Co-authored-by: cristianastan2 <[email protected]> Co-authored-by: John Halley Gotway <[email protected]> Co-authored-by: bikegeek <[email protected]> Co-authored-by: Lisa Goodrich <[email protected]> Co-authored-by: Julie Prestopnik <[email protected]> Co-authored-by: George McCabe <[email protected]> Co-authored-by: Hank Fisher <[email protected]> Co-authored-by: Dan Adriaansen <[email protected]> Co-authored-by: jprestop <[email protected]> Co-authored-by: Tracy Hertneky <[email protected]> Co-authored-by: j-opatz <[email protected]> Co-authored-by: lisagoodrich <[email protected]> Co-authored-by: bikegeek <[email protected]> Co-authored-by: j-opatz <[email protected]> Co-authored-by: Will Mayfield <[email protected]> Co-authored-by: metplus-bot <[email protected]> Co-authored-by: Tracy Hertneky <[email protected]> fixing some spacing #770 Fixing formatting, typos etc. #770 Fixing formatting #770 fixing typos, spacing, etc. #770 fixing typos, grammar and punctuation. #770 Fixing TOC and coding block #770 fixing note #770 fix. Updating bolding and italics for file names and directories #770 fixing space #770 fixing conflict #2 #770 fixing typos #770 fixing typos #2 #770 fixing formatting #770 fixing errors #650 fixing errors take 2 #650 fixing errors take 3 #650 fixing errors take 4 #650 fixing errors take 5 #650 fixing question order #650 fix #1706 fix PhaseDiagram use case to avoid writing into INPUT_BASE (#1708) fix #1713 develop METPLOTPY_BASE (#1715) fix #1691 remove whitespace from output file paths (#1721) fix Contributor's Guide GitHub Workflow page (#1774) fix release (#1790) fix GitHub Actions warnings (#1864) fix #1884 develop PCPCombine {custom} in subtract method (#1887) fix #1939 develop - failure reading obs when zipped file also exists (#1941) Closes #1986 fix develop Fix broken documentation links (#2004) fix #2026 develop StatAnalysis looping (#2028) fix priority of obs_window config variables so that wrapper-specific version is preferred over generic OBS_WINDOW_BEGIN/END (#2062) fix #2070 var list numeric order (#2072) fix #2087 develop docs_pdf (#2091) fix #2096/#2098 develop - fix skip if output exists and do not error if no commands were run (#2099)
georgemccabe
pushed a commit
that referenced
this pull request
Apr 28, 2023
Co-authored-by: Julie Prestopnik <[email protected]> Co-authored-by: johnhg <[email protected]> Co-authored-by: cristianastan2 <[email protected]> Co-authored-by: John Halley Gotway <[email protected]> Co-authored-by: bikegeek <[email protected]> Co-authored-by: Lisa Goodrich <[email protected]> Co-authored-by: Julie Prestopnik <[email protected]> Co-authored-by: George McCabe <[email protected]> Co-authored-by: Hank Fisher <[email protected]> Co-authored-by: Dan Adriaansen <[email protected]> Co-authored-by: jprestop <[email protected]> Co-authored-by: Tracy Hertneky <[email protected]> Co-authored-by: Giovanni Rosa <[email protected]> Co-authored-by: j-opatz <[email protected]> Co-authored-by: lisagoodrich <[email protected]> Co-authored-by: bikegeek <[email protected]> Co-authored-by: j-opatz <[email protected]> Co-authored-by: Will Mayfield <[email protected]> Co-authored-by: metplus-bot <[email protected]> Co-authored-by: Tracy Hertneky <[email protected]> Co-authored-by: Giovanni Rosa <[email protected]> fixing errors #650 fixing errors take 2 #650 fixing errors take 3 #650 fixing errors take 4 #650 fixing errors take 5 #650 fixing question order #650 fix #1706 fix PhaseDiagram use case to avoid writing into INPUT_BASE (#1708) fix #1713 develop METPLOTPY_BASE (#1715) fix #1691 remove whitespace from output file paths (#1721) fix Contributor's Guide GitHub Workflow page (#1774) fix release (#1790) fix GitHub Actions warnings (#1864) fix #1884 develop PCPCombine {custom} in subtract method (#1887) fix #1939 develop - failure reading obs when zipped file also exists (#1941) Closes #1986 fix develop Fix broken documentation links (#2004) fix #2026 develop StatAnalysis looping (#2028) fix priority of obs_window config variables so that wrapper-specific version is preferred over generic OBS_WINDOW_BEGIN/END (#2062) fix #2070 var list numeric order (#2072) fix #2087 develop docs_pdf (#2091) fix #2096/#2098 develop - fix skip if output exists and do not error if no commands were run (#2099) Fix for Dockerfile smell DL4000 (#2112) fix #2082 develop regrid.convert/censor_thresh/censor_val (#2140) fix #2082 main_v5.0 regrid.convert/censor_thresh/censor_val (#2101) fix #2137 develop PointStat -obs_valid_beg/end (#2141)
JohnHalleyGotway
pushed a commit
that referenced
this pull request
May 11, 2023
Co-authored-by: Julie Prestopnik <[email protected]> Co-authored-by: johnhg <[email protected]> Co-authored-by: cristianastan2 <[email protected]> Co-authored-by: John Halley Gotway <[email protected]> Co-authored-by: bikegeek <[email protected]> Co-authored-by: Lisa Goodrich <[email protected]> Co-authored-by: Julie Prestopnik <[email protected]> Co-authored-by: George McCabe <[email protected]> Co-authored-by: Hank Fisher <[email protected]> Co-authored-by: Dan Adriaansen <[email protected]> Co-authored-by: jprestop <[email protected]> Co-authored-by: Tracy Hertneky <[email protected]> Co-authored-by: Giovanni Rosa <[email protected]> Co-authored-by: j-opatz <[email protected]> Co-authored-by: lisagoodrich <[email protected]> Co-authored-by: bikegeek <[email protected]> Co-authored-by: j-opatz <[email protected]> Co-authored-by: Will Mayfield <[email protected]> Co-authored-by: metplus-bot <[email protected]> Co-authored-by: Tracy Hertneky <[email protected]> Co-authored-by: Giovanni Rosa <[email protected]> fixing errors #650 fixing errors take 2 #650 fixing errors take 3 #650 fixing errors take 4 #650 fixing errors take 5 #650 fixing question order #650 fix #1706 fix PhaseDiagram use case to avoid writing into INPUT_BASE (#1708) fix #1713 develop METPLOTPY_BASE (#1715) fix #1691 remove whitespace from output file paths (#1721) fix Contributor's Guide GitHub Workflow page (#1774) fix release (#1790) fix GitHub Actions warnings (#1864) fix #1884 develop PCPCombine {custom} in subtract method (#1887) fix #1939 develop - failure reading obs when zipped file also exists (#1941) Closes #1986 fix develop Fix broken documentation links (#2004) fix #2026 develop StatAnalysis looping (#2028) fix priority of obs_window config variables so that wrapper-specific version is preferred over generic OBS_WINDOW_BEGIN/END (#2062) fix #2070 var list numeric order (#2072) fix #2087 develop docs_pdf (#2091) fix #2096/#2098 develop - fix skip if output exists and do not error if no commands were run (#2099) Fix for Dockerfile smell DL4000 (#2112) fix #2082 develop regrid.convert/censor_thresh/censor_val (#2140) fix #2082 main_v5.0 regrid.convert/censor_thresh/censor_val (#2101) fix #2137 develop PointStat -obs_valid_beg/end (#2141) fix failured introduced by urllib3 (see urllib3/urllib3#2168) fix #2161 develop PCPCombine additional field arguments in -subtract mode (#2162)
georgemccabe
pushed a commit
that referenced
this pull request
Jun 5, 2023
Co-authored-by: Julie Prestopnik <[email protected]> Co-authored-by: johnhg <[email protected]> Co-authored-by: cristianastan2 <[email protected]> Co-authored-by: John Halley Gotway <[email protected]> Co-authored-by: bikegeek <[email protected]> Co-authored-by: Lisa Goodrich <[email protected]> Co-authored-by: Julie Prestopnik <[email protected]> Co-authored-by: George McCabe <[email protected]> Co-authored-by: Hank Fisher <[email protected]> Co-authored-by: Dan Adriaansen <[email protected]> Co-authored-by: jprestop <[email protected]> Co-authored-by: Tracy Hertneky <[email protected]> Co-authored-by: Giovanni Rosa <[email protected]> Co-authored-by: j-opatz <[email protected]> Co-authored-by: Mrinal Biswas <[email protected]> Co-authored-by: lisagoodrich <[email protected]> Co-authored-by: bikegeek <[email protected]> Co-authored-by: j-opatz <[email protected]> Co-authored-by: Will Mayfield <[email protected]> Co-authored-by: metplus-bot <[email protected]> Co-authored-by: Tracy Hertneky <[email protected]> Co-authored-by: Giovanni Rosa <[email protected]> Co-authored-by: mrinalbiswas <[email protected]> fixing errors #650 fixing errors take 2 #650 fixing errors take 3 #650 fixing errors take 4 #650 fixing errors take 5 #650 fixing question order #650 fix #1706 fix PhaseDiagram use case to avoid writing into INPUT_BASE (#1708) fix #1713 develop METPLOTPY_BASE (#1715) fix #1691 remove whitespace from output file paths (#1721) fix Contributor's Guide GitHub Workflow page (#1774) fix release (#1790) fix GitHub Actions warnings (#1864) fix #1884 develop PCPCombine {custom} in subtract method (#1887) fix #1939 develop - failure reading obs when zipped file also exists (#1941) Closes #1986 fix develop Fix broken documentation links (#2004) fix #2026 develop StatAnalysis looping (#2028) fix priority of obs_window config variables so that wrapper-specific version is preferred over generic OBS_WINDOW_BEGIN/END (#2062) fix #2070 var list numeric order (#2072) fix #2087 develop docs_pdf (#2091) fix #2096/#2098 develop - fix skip if output exists and do not error if no commands were run (#2099) Fix for Dockerfile smell DL4000 (#2112) fix #2082 develop regrid.convert/censor_thresh/censor_val (#2140) fix #2082 main_v5.0 regrid.convert/censor_thresh/censor_val (#2101) fix #2137 develop PointStat -obs_valid_beg/end (#2141) fix failured introduced by urllib3 (see urllib3/urllib3#2168) fix #2161 develop PCPCombine additional field arguments in -subtract mode (#2162) fix #2168 develop - StatAnalysis time shift (#2169) fix releases. (#2183) fix #2189 develop - spaces in complex thresholds (#2191)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponding PR for develop is #1709
Pull Request Testing
Ran PhaseDiagram use case that previously failed locally if INPUT_BASE is not writable by the user and confirmed that it now works.
Confirm that changes look OK and that all automated tests pass except the diff for the new output file that is now written by the use case in OUTPUT_BASE
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
Do these changes include sufficient testing updates? [Yes]
Will this PR result in changes to the test suite? [Yes]
If yes, describe the new output and/or changes to the existing output:
The time_list_lead000.txt may flag a difference since it is now written into OUTPUT_BASE
Please complete this pull request review by 7/26/2022.
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s)
Select: Organization level software support Project or Repository level development cycle Project
Select: Milestone as the version that will include these changes