Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for probability field threshold in SeriesAnalysis #875

Closed
6 of 21 tasks
j-opatz opened this issue Apr 12, 2021 · 0 comments · Fixed by #942
Closed
6 of 21 tasks

Add support for probability field threshold in SeriesAnalysis #875

j-opatz opened this issue Apr 12, 2021 · 0 comments · Fixed by #942
Assignees
Labels
priority: low Low Priority requestor: NCAR National Center for Atmospheric Research type: enhancement Improve something that it is currently doing
Milestone

Comments

@j-opatz
Copy link
Contributor

j-opatz commented Apr 12, 2021

Describe the Enhancement

Currently in SeriesAnalysis, if the forecast or observation field is set as a probability, it needs to have a probability threshold. However, there is no dedicated variable for this (i.e. FCST_SERIES_ANALAYSIS_PROB_THRESH) as there is in GridStat and Point2Grid. This enhancement is to create that variable and allow iterative thresholds (via ==) to be set.

Time Estimate

The issue for this is being created retroactively, so the work did take about an hour or so.

Sub-Issues

Consider breaking the enhancement down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

Needed for Probability of Exceedance (POE) work with CPC data, but no set deadline

Funding Source

None

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@j-opatz j-opatz added alert: NEED MORE DEFINITION Not yet actionable, additional definition required type: new use case Add a new use case labels Apr 12, 2021
@j-opatz j-opatz self-assigned this Apr 12, 2021
@georgemccabe georgemccabe added this to the METplus-4.1.0 milestone May 18, 2021
@j-opatz j-opatz added priority: low Low Priority requestor: NCAR National Center for Atmospheric Research type: enhancement Improve something that it is currently doing and removed type: new use case Add a new use case alert: NEED MORE DEFINITION Not yet actionable, additional definition required labels May 27, 2021
@j-opatz j-opatz changed the title POE precipitation data using SeriesAnalysis Probability field threshold control in SeriesAnalysis May 27, 2021
@j-opatz j-opatz removed a link to a pull request Jun 1, 2021
12 tasks
@j-opatz j-opatz closed this as completed Jun 1, 2021
@georgemccabe georgemccabe changed the title Probability field threshold control in SeriesAnalysis Added support for probability field threshold in SeriesAnalysis Jul 21, 2021
@georgemccabe georgemccabe changed the title Added support for probability field threshold in SeriesAnalysis Add support for probability field threshold in SeriesAnalysis Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low Low Priority requestor: NCAR National Center for Atmospheric Research type: enhancement Improve something that it is currently doing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants