Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for many commonly changed MET config variables #779

Closed
20 of 21 tasks
georgemccabe opened this issue Jan 26, 2021 · 3 comments · Fixed by #858, #860, #888, #893 or #894
Closed
20 of 21 tasks

Add support for many commonly changed MET config variables #779

georgemccabe opened this issue Jan 26, 2021 · 3 comments · Fixed by #858, #860, #888, #893 or #894
Assignees
Labels
component: python wrapper METplus: Configuration priority: high High Priority requestor: METplus Team METplus Development Team requestor: NOAA/EMC NOAA Environmental Modeling Center requestor: UK Met Office United Kingdom Met Office type: enhancement Improve something that it is currently doing
Milestone

Comments

@georgemccabe
Copy link
Collaborator

georgemccabe commented Jan 26, 2021

We would like to support setting MET config variables through the wrappers for values that are likely to be changed from the default. This will reduce the need for user's to create their own wrapped MET config files to configure.

Here is a list of variables from @malloryprow that she has changed:

GridStat: model, desc, obtype, regrid, fcst, obs, climo_mean, mask,
fourier, output_flag, grid_weight_flag, tmp_dir, output_prefix, version
StatAnalysis: model, fcst_lead, fcst_valid_beg, fcst_valid_end,
fcst_valid_hour, fcst_init_beg, fcst_init_end, fcst_init_hour, fcst_var,
obs_var, fcst_lev, obs_lev, obtype, vx_mask, interp_mthd, fcst_thresh,
line_type, jobs, tmp_dir, version
PB2NC: message_type, obs_window, pb_report_type, level_category,
obs_bufr_var, obs_prepbufr_map, quality_mark_thresh, tmp_dir, version
PointStat: model, regrid, fcst, obs, message_type, obs_window, mask,
output_flag, tmp_dir, version
TcPairs: model, storm_id, basin, cyclone, storm_name, init_beg, init_end,
init_inc, init_exc, valid_beg, valid_end, check_dup, interp12,
match_points, version
SerisAnalysis: model, obtype, regrid, fcst, obs, block_size,
output_stats, tmp_dir, version

Describe the Enhancement

Add support for setting environment variables from METplus config settings.

Time Estimate

3 days - we should divide this into sub-tasks for different tools.

Sub-Issues

Consider breaking the enhancement down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

Ideally for 4.0.0

Funding Source

2791541 and 2799991

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Review projects and select relevant Repository and Organization ones or add "alert:NEED PROJECT ASSIGNMENT" label
  • Select milestone to next major version milestone or "Future Versions"

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s), Project(s), Milestone, and Linked issues
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@georgemccabe georgemccabe added type: enhancement Improve something that it is currently doing component: python wrapper component: use case configuration priority: high High Priority requestor: NOAA/EMC NOAA Environmental Modeling Center alert: NEED ACCOUNT KEY Need to assign an account key to this issue requestor: METplus Team METplus Development Team labels Jan 26, 2021
@georgemccabe georgemccabe added this to the METplus-4.0 milestone Jan 26, 2021
@georgemccabe georgemccabe self-assigned this Jan 26, 2021
@georgemccabe georgemccabe linked a pull request Mar 30, 2021 that will close this issue
11 tasks
@TaraJensen TaraJensen added requestor: UK Met Office United Kingdom Met Office and removed alert: NEED ACCOUNT KEY Need to assign an account key to this issue labels Mar 31, 2021
@georgemccabe georgemccabe linked a pull request Apr 21, 2021 that will close this issue
11 tasks
@georgemccabe
Copy link
Collaborator Author

georgemccabe commented Apr 21, 2021

PR #888 handles unsupported MODE configs

  • fcst.filter_attr_name
  • fcst.filter_attr_thresh
  • fcst.censor_thresh
  • fcst.censor_val
  • fcst.vld_thresh
  • obs.filter_attr_name
  • obs.filter_attr_thresh
  • obs.censor_thresh
  • obs.censor_val
  • obs.vld_thresh
  • mask dictionary (all values: grid, poly, grid_flag, poly_flag)
  • weight dictionary (all values)
  • nc_pairs dictionary (all values)
  • match_flag
  • max_centroid_dist
  • total_interest_thresh
  • interest_function.centroid_dist
  • interest_function.boundary_dist
  • interest_function.convex_hull_dist

It also handles unsupported PointStat configs:

  • obs_quality
  • output_flag dictionary (all values)
  • interp dictionary (all values: vld_thresh, shape, type.method, and type.width)
  • climo_mean.time_interp_method
  • climo_stdev.time_interp_method

@georgemccabe
Copy link
Collaborator Author

PR #893 added support for PB2NC config variables:

  • pb_report_type
  • level_range dictionary (all items: beg and end)
  • level_category
  • quality_mark_thresh

PR #894 added support in GridStat wrapper for:

  • interp dictionary (all items)
  • nc_pairs_var_name
  • grid_weight_flag
  • fcst.file_type
  • obs.file_type
  • climo_mean and climo_stdev dictionaries (all items)

Also added support for all climo_mean and climo_stdev items for

  • SeriesAnalysis wrapper
  • PointStat wrapper
  • EnsembleStat wrapper

@georgemccabe
Copy link
Collaborator Author

georgemccabe commented Apr 27, 2021

Closing this issue so it is tied to the 4.0.0 release. Remaining work will be documented in #896 for the 4.1.0 release.

@georgemccabe georgemccabe changed the title Add support for commonly changed MET config variables Add support for many commonly changed MET config variables Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment