Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal: Update diff logic to handle CSV files that have rounding differences #1865

Closed
22 tasks
georgemccabe opened this issue Oct 12, 2022 · 1 comment
Closed
22 tasks
Assignees
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue component: testing Software testing issue priority: high High Priority reporting: DTC AF METplus Air Force METplus Project requestor: METplus Team METplus Development Team type: enhancement Improve something that it is currently doing
Milestone

Comments

@georgemccabe
Copy link
Collaborator

The s2s_mjo:4 use case produces CSV files that have rounding differences in the values.

Describe the Enhancement

Update the diff logic in metplus/util/diff_util.py to handle this situation and diff the numeric values using 6 digits of precision.

Time Estimate

Estimate the amount of work required here.
Issues should represent approximately 1 to 3 days of work.

Sub-Issues

Consider breaking the enhancement down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Add any new Python packages to the METplus Components Python Requirements table.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@georgemccabe georgemccabe added type: enhancement Improve something that it is currently doing alert: NEED MORE DEFINITION Not yet actionable, additional definition required alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle labels Oct 12, 2022
@georgemccabe georgemccabe self-assigned this Oct 12, 2022
@georgemccabe georgemccabe added component: testing Software testing issue priority: high High Priority requestor: METplus Team METplus Development Team and removed alert: NEED MORE DEFINITION Not yet actionable, additional definition required alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle labels Oct 12, 2022
@georgemccabe georgemccabe added this to the METplus-5.0.0 milestone Oct 12, 2022
@georgemccabe
Copy link
Collaborator Author

This is a duplicate of #1874, which was completed with PR #1875

Repository owner moved this from Todo to Done in METplus-Wrappers-5.0.0-beta4 (10/26/22) Oct 20, 2022
@TaraJensen TaraJensen added the reporting: DTC AF METplus Air Force METplus Project label Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue component: testing Software testing issue priority: high High Priority reporting: DTC AF METplus Air Force METplus Project requestor: METplus Team METplus Development Team type: enhancement Improve something that it is currently doing
Projects
No open projects
Development

No branches or pull requests

2 participants