Internal: Rename internal_tests directory to internal

[georgemccabe]

We would like to be consistent across METplus components, so we should rename this directory to match what MET uses.

Describe the Task

• Rename the internal_tests directory to internal
• Rename the internal_tests/scanning directory to internal/scripts
• Update any scripts that reference these files
• Coordinate with @hsoh-u to ensure that any necessary changes to the automated sonarqube runs are made

Time Estimate

~1 day

Sub-Issues

Consider breaking the task down into sub-issues.

• Add a checkbox for each sub-issue here.

Relevant Deadlines

by 5.0.0

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

• Select engineer(s) or no engineer required
• no scientist required

Labels

• Select component(s)
• Select priority
• Select requestor(s)

Projects and Milestone

• Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
• Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.
Corresponding issues for METdataio, METplotpy, and METcalcy (and others?) should be created

• METplus, MET, METdataio, METviewer, METexpress, METcalcpy, METplotpy

Task Checklist

See the METplus Workflow for details.

• Complete the issue definition above, including the Time Estimate and Funding Source.
• Fork this repository or create a branch of develop.
  Branch name: feature_<Issue Number>_<Description>
• Complete the development and test your changes.
• Add/update log messages for easier debugging.
• Add/update unit tests.
• Add/update documentation.
• Add any new Python packages to the METplus Components Python Requirements table.
• Push local changes to GitHub.
• Submit a pull request to merge into develop.
  Pull request: feature <Issue Number> <Description>
• Define the pull request metadata, as permissions allow.
  Select: Reviewer(s) and Linked issues
  Select: Repository level development cycle Project for the next official release
  Select: Milestone as the next official version
• Iterate until the reviewer(s) accept and merge your changes.
• Delete your fork or branch.
• Close this issue.

[jprestop]

@georgemccabe Should scripts/docker also move to internal? That would be consistent with the MET repo.

[georgemccabe]

@georgemccabe Should scripts/docker also move to internal? That would be consistent with the MET repo.

@jprestop, I suppose it would be nice to be consistent across repos. We will need to update the build rules on DockerHub dtcenter/metplus while preserving the old location for any bugfix releases to 4.1. This could be accomplished by creating a new build rule that matches v4.1* pointing to the old location of the docker directory and update the existing build rules to point to the new location.