Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions to update old METplus configuration files that reference user-defined wrapped MET config files #1147

Closed
9 of 21 tasks
georgemccabe opened this issue Sep 8, 2021 · 1 comment · Fixed by #1152
Assignees
Labels
component: documentation Documentation issue METplus: Configuration priority: high High Priority requestor: METplus Team METplus Development Team requestor: NOAA/EMC NOAA Environmental Modeling Center type: enhancement Improve something that it is currently doing
Milestone

Comments

@georgemccabe
Copy link
Collaborator

Related to discussion #996

Describe the Enhancement

Add useful instructions to assist users who need to update their configurations to use the wrapped MET config files in parm/met_config instead of their own MET config files. This involves determining which variables in the user's wrapped MET config file differ from the wrapped version in parm/met_config (considering the variables in the parm/met_config version that mistakenly differ from the default MET values before v4.0.0).

Respond to GitHub Discussion topic listed above with info and consider adding this information to User's Guide

Time Estimate

~3 days

Sub-Issues

Consider breaking the enhancement down into sub-issues.

  • Add logic for writing metplus_final.conf to move variables that are specific to that run (i.e. CLOCK_TIME) to a runtime section so that it is clear which variables are relevant if rerunning

Relevant Deadlines

4.1.0-beta3 (if possible)

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@georgemccabe georgemccabe added type: enhancement Improve something that it is currently doing component: documentation Documentation issue priority: high High Priority requestor: NOAA/EMC NOAA Environmental Modeling Center alert: NEED ACCOUNT KEY Need to assign an account key to this issue requestor: METplus Team METplus Development Team METplus: Configuration labels Sep 8, 2021
@georgemccabe georgemccabe added this to the METplus-4.1.0 milestone Sep 8, 2021
@georgemccabe georgemccabe self-assigned this Sep 8, 2021
@georgemccabe georgemccabe linked a pull request Sep 10, 2021 that will close this issue
12 tasks
@georgemccabe
Copy link
Collaborator Author

Updated #996 to include a detailed summary of the process to update old wrapped MET config files. Directing users to this discussion topic is likely sufficient for providing this information, so adding the same content to the User's Guide may not be necessary. Closing this issue, but please re-open if adding to the user's guide is desired.

@georgemccabe georgemccabe removed the alert: NEED ACCOUNT KEY Need to assign an account key to this issue label Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: documentation Documentation issue METplus: Configuration priority: high High Priority requestor: METplus Team METplus Development Team requestor: NOAA/EMC NOAA Environmental Modeling Center type: enhancement Improve something that it is currently doing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant