Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load new DMAP columns for G and GBETA. #62

Closed
8 of 20 tasks
JohnHalleyGotway opened this issue Aug 18, 2021 · 3 comments
Closed
8 of 20 tasks

Load new DMAP columns for G and GBETA. #62

JohnHalleyGotway opened this issue Aug 18, 2021 · 3 comments
Assignees
Labels
METdataio: Load STAT Data priority: high High Priority reporting: DTC NCAR Base NCAR Base DTC Project requestor: METplus Team METplus Development Team required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: enhancement Improve something that it is currently doing
Milestone

Comments

@JohnHalleyGotway
Copy link
Contributor

Describe the Enhancement

The issue dtcenter/MET#1673 and corresponding pull request dtcenter/MET#1857 add new columns to the distance map (DMAP) line type created by the Grid-Stat tool.

This adds 3 new columns to the end of the existing DMAP line type: G, GBETA, and BETA_VALUE. All 3 columns are floating point numbers. Note that G will always have a value in the output, but GBETA and BETA_VALUE will only have a value when VX_MASK = FULL. When VX_MASK != FULL, GBETA = BETA_VALUE = NA.

Please see corresponding METviewer issue for plotting these stats:
dtcenter/METviewer#323

Please see existing documentation for more details about the configuration options, science, and equations.

Sample data can be found in kiowa:/d1/projects/MET/MET_regression/develop/NB20210818/MET-develop/test_output/met_test_scripts/grid_stat/grid_stat_120000L_20050807_120000V_dmap.txt.

Time Estimate

Estimate the amount of work required here.
Issues should represent approximately 1 to 3 days of work.

Sub-Issues

Consider breaking the enhancement down into sub-issues.
No sub-issues needed.

Relevant Deadlines

Prior to the coordinated METplus 4.1.0 release.

Funding Source

2702691

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required: Venita
  • Select scientist(s) or no scientist required: no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@JohnHalleyGotway JohnHalleyGotway added type: enhancement Improve something that it is currently doing priority: high High Priority requestor: METplus Team METplus Development Team required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone METdataio: Load STAT Data labels Aug 18, 2021
@JohnHalleyGotway JohnHalleyGotway added this to the METdatadb-1.1 milestone Aug 18, 2021
@TatianaBurek
Copy link
Collaborator

Here is the sample data (remove.txt)
grid_stat_120000L_20050807_120000V.stat.txt

@TatianaBurek
Copy link
Collaborator

@venitahagerty
Copy link
Contributor

Added new fields g, g_beta, and beta_value to line_data_dmap in constants.py. Requires version of mv_mysql.sql with new columns in line_data_dmap (in METviewer repo). Ran with test data file provided by Tatiana.

@TaraJensen TaraJensen added the reporting: DTC NCAR Base NCAR Base DTC Project label Oct 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
METdataio: Load STAT Data priority: high High Priority reporting: DTC NCAR Base NCAR Base DTC Project requestor: METplus Team METplus Development Team required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: enhancement Improve something that it is currently doing
Projects
None yet
Development

No branches or pull requests

4 participants