Bugfix #2482 main_v11.0 time slicing yyyymmdd #2484
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expected Differences
The 8 digits number should be interpreted as yyyymmdd (converted to unixtime in seconds unit).
Do these changes introduce new tools, command line arguments, or configuration file options? [No]
If yes, please describe:
Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]
If yes, please describe:
Pull Request Testing
This command does not work because $MET_TEST_INPUT (/d1/projects/MET/MET_test_data/unit_test) is not mounted at seneca.
Alternative test:
/d1/personal/hsoh/git/pull_request/MET_bugfix_2482_timeslicing_yyyymmdd_main_v11.0/bin/plot_data_plane /d1/projects/MET/MET_test_data/unit_test.sav/model_data/nccf/GloTEC_TEC_2015_03_17.nc tmp_test.ps 'name="TEC"; level="(20150317,,)"; file_type=NETCDF_NCCF;' -v 4
Before: "20150317" to 20150317
After: "20150317" to 1426550400
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]
Do these changes include sufficient testing updates? [Yes or No]
Will this PR result in changes to the test suite? [Yes or No]
If yes, describe the new output and/or changes to the existing output:
Please complete this pull request review by [Fill in date].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s)
Select: Organization level software support Project or Repository level development cycle Project
Select: Milestone as the version that will include these changes