Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature update installation #2384

Merged
merged 3 commits into from
Dec 21, 2022
Merged

Conversation

jprestop
Copy link
Collaborator

Expected Differences

  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

  • Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:

    Used the compilation script included in this PR to install on various machines with the associated configuration files and modulefiles.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    Review files changed if desired.

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [N/A]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [ASAP].

Pull Request Checklist

See the METplus Workflow for details.

  • [N/A - no issue] Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • [N/A - no issue] After submitting the PR, select Development issue with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@jprestop jprestop added this to the MET 11.0.1 (bugfix) milestone Dec 21, 2022
@jprestop
Copy link
Collaborator Author

All tests passed. Urgency is needed to merge this PR. No installation scripts and their associated configuration and modulefiles should have any effect on any other parts of main_v11.0. Squashing and merging without review.

@jprestop jprestop merged commit 4e3fd45 into main_v11.0 Dec 21, 2022
@jprestop jprestop deleted the feature_update_installation branch December 21, 2022 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

1 participant