Update develop-ref after #2256, and #2257, and #2262. #2263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ar entry should really be obs_bufr_map and not commented out.
Feature 2044 pb2nc config
Co-authored-by: Howard Soh <[email protected]>
#1824 ci-run-test Reset itype to 1 for regular CAPE
* found and made three changes replacing [email protected] with the MetPlus gitub discussions page * Update met/docs/Users_Guide/appendixA.rst Thanks, a typo plus I am completely neutral as to the exact wording. Co-authored-by: jprestop <[email protected]> * Update met/src/libcode/vx_data2d_grib2/data2d_grib2.cc Co-authored-by: jprestop <[email protected]> * Update met/README Co-authored-by: jprestop <[email protected]> Co-authored-by: jprestop <[email protected]>
Feature 1996 sonarqube findings
* Updated set_job_controls.sh to add a check for the skip all keyword * Added a space to check keyword ci-skip-all Co-authored-by: Julie Prestopnik <[email protected]>
Feature 1996 sonarqube findings
* Per #1918, store the ensemble_member_id string in the EnsVarInfo class so that we can use it later, if needed, when reading climatological data which may also make use of that string. * Per #1918, update gen_ens_prod to set the MET_ENS_MEMBER_ID environment variable when reading climatology data if the ens_member_ids config option has been set and the normalizing relative to climatology has been requested. * Per #1918, add log messages to read_climo.cc and gen_ens_prod.cc to clarify what data is being read from which climo data files. * Added documentation on MET_ENS_MEMBER_ID usage in climo file name * updated usage langauge * Per #1918, adding gen_ens_prod unit test to demonstrate using ENS_MEMBER_ID to read climo data separately for each member. * Per #1918, adding gen_ens_prod unit test to demonstrate using ENS_MEMBER_ID to read climo data separately for each member. Co-authored-by: j-opatz <[email protected]>
feature_2225_level_string_with_at
…id_stat, gribtab_dat_to_flat, and gsidens2orank). Also removed commented out code from main.cc.
* Per #2198, adding Seth Linden and Dave Albo to the Author List * Per #2198, updated Dave Albo to David Albo * Per #2198, added three new authors based on submitted AMS abstract * Per #2198, adding .zenodo.json file * Per #2198, adding orcids for all based on Tatiana's suggestion * Update .zenodo.json Co-authored-by: johnhg <[email protected]> * Update .zenodo.json Co-authored-by: johnhg <[email protected]> * Update .zenodo.json Co-authored-by: johnhg <[email protected]> Co-authored-by: johnhg <[email protected]>
* Per #2196, update for upgrade to Python 3.8.6 * Updated based on new structure of METbaseimage * Changed MET_BASE_IMAGE references to MET_BASE_TAG; Added information to the README.md file * Changed MET_BASE_IMAGE references to MET_BASE_TAG; Updated the version from v1.0 to v1.1 * Update internal/scripts/docker/README.md Based on suggestion from John HG. Co-authored-by: johnhg <[email protected]> * Update internal/scripts/docker/README.md Based on suggestion from John HG. Co-authored-by: johnhg <[email protected]> * Update internal/scripts/docker/README.md Based on suggestion from John HG. Co-authored-by: johnhg <[email protected]> * Update internal/scripts/docker/README.md Based on suggestion from John HG. Co-authored-by: johnhg <[email protected]> * Per #2196, updating README.md based on suggestions from John HG Co-authored-by: johnhg <[email protected]>
* creating chapter files * putting a space in to work through the git add and commit process. * Changed formatting of one header Co-authored-by: Lisa Goodrich <[email protected]> Co-authored-by: jprestop <[email protected]>
* Per issue #2206, for the ECNT line type, added CRPS_EMP_FAIR. SL * Per issue #2206, for ECNT line type, added CRPS_EMP_FAIR. SL * Per issue #2206, for ecnt_columns, added CRPS_EMP_FAIR. SL * Per issue #2206, in write_ecnt_cols(), added crps_emp_fair. SL * Per issue #2206, in ECNTInfo, added crps_emp_fair. SL * Per issue #2206, started stubbing code pieced to calculate crps_emp_fair. SL * Per issue #2206, added new function mean_abs_diff(). SL * Per issue #2206, in compute_pair_vals() updated the code to calculate crps_emp and crps_emp_fair. SL * Per issue #2206, added crps_emp_fair (CRPS_EMP_FAIR) to relevant code pieces. SL * Per issue #2206, added wording for CRPS_EMP_FAIR, also added it to last column of ECNT line type. SL * Per issue #2206, added info for CRPS_EMP_FAIR and also added the math equation for this. SL * Per issue #2206, update the math equation for CRPS_EMP_FAIR. SL * Per issue #2206, added new function weighted_mean_absolute_diff(). SL * Per issue #2206, updated the crps_emp_fair calculation to subtract the weighted_mean_abs_diff. SL * Per issue #2206, in aggr_orank_lines(), updated calculation for crps_emp_fair to use weighted_mean_abs_diff. SL * Per issue #2206, renamed weighted_mean_abs_diff() to wmean_abs_diff(). SL * Per issue #2206, for the crps_emp_fair calculation, changed weighted_mean_abs_diff() to wmean_abs_diff(). SL * Per issue #2206, in aggr_orank_lines(), for the crps_emp_fair calculation, changed weighted_mean_abs_diff() to wmean_abs_diff(). SL * Per issue #2206, updated the math equation for the CRPS_EMP_FAIR calculation. SL * Per issue #2206, fixed a bug in the wmean_abs_diff() function. SL * Per issue #2206, added code for crps_emp_fair. SL * Per issue #2206, in set() function, added checks for crps_emp and crps_emp_fair, for values of 0.0. SL Co-authored-by: Seth Linden <[email protected]>
…r image that it used in the METplus automated tests
…elopment.docker file (apparently unused or rarely previously) to include changes for Python 3.8 including setting the LDFLAG to include -rpath to prevent needing LD_LIBRARY_PATH set to run the tools. Source the env file in the build MET docker script instead of setting the env vars in the configure command
…ck to 3.6. This is done by rolling back the base image in the MET Dockerfiles to dtcenter/met-base:v1.0. Using 3.8 caused the downstream METplus python embedding examples to fail via GHA in the METplus repo. Will write up an issue to investigate more during the MET-11.0.0-beta4 development cycle.
…BASE_IMAGE and MET_BASE_TAG since those variables are hard-coded in the Dockerfiles themselves and this script includes no logic to handle them.
… to MET_BASE_IMAGE and MET_BASE_TAG since those variables are hard-coded in the Dockerfiles themselves and this script includes no logic to handle them." This reverts commit 5efc65e.
…should really revisit having this setting spread across so many locations.
Co-authored-by: Howard Soh <[email protected]>
Co-authored-by: jprestop <[email protected]> Co-authored-by: John Halley Gotway <[email protected]>
Co-authored-by: Howard Soh <[email protected]> Co-authored-by: John Halley Gotway <[email protected]>
Co-authored-by: Howard Soh <[email protected]> Co-authored-by: John Halley Gotway <[email protected]> Co-authored-by: MET Tools Test Account <[email protected]>
Co-authored-by: Dave Albo <[email protected]> Co-authored-by: John Halley Gotway <[email protected]>
Co-authored-by: j-opatz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expected Differences
Updating develop-ref after 3 recent pull requests changed the expected output.
See this GHA run for a summary of all the diffs.
The only differences flagged are the addition of 3 new ascii2nc output files:
This adds 9 new output files from a new call to Point-Stat:
This modifies 7 existing output files since TP24 was added to the corresponding PB2NC config file:
This adds 3 new output files to demonstrate the semilatlon grid type:
This modifies multivar MODE NetCDF attributes slightly:
Updating develop-ref to get past these 3 sources of difference.