Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance contents of VCNT line type to actually compute the bootstrap confidence intervals #963

Open
6 of 20 tasks
dwfncar opened this issue Mar 2, 2018 · 2 comments
Open
6 of 20 tasks
Assignees
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle MET: Wind Verification priority: medium Medium Priority requestor: METplus Team METplus Development Team type: enhancement Improve something that it is currently doing

Comments

@dwfncar
Copy link
Contributor

dwfncar commented Mar 2, 2018

Describe the Enhancement

MET version 7.0 added the new VCNT line type for vector continuous statistics. However, it is incomplete. We added placeholder columns for bootstrap CI's but they are currently set to NA. This task is to actually go through and compute the bootstrap CI's in MET. This applies to the Point-Stat, Grid-Stat, Series-Analysis, and Stat-Analysis tools.

Time Estimate

2-3 days

Sub-Issues

Consider breaking the enhancement down into sub-issues.
No sub-issues needed.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@JohnHalleyGotway
Copy link
Collaborator

Note that this issue resurfaced when beginning work on #2022. The VCNT line type includes many columns for BCL and BCU output. They are currently just hard-coded to write NA. If we're going to have those columns, we should populate them... or decide that populating them isn't worthwhile and remove the BCL and BCU columns.

@JohnHalleyGotway JohnHalleyGotway added type: enhancement Improve something that it is currently doing priority: medium Medium Priority requestor: METplus Team METplus Development Team MET: Wind Verification labels Apr 8, 2022
@JohnHalleyGotway
Copy link
Collaborator

Development for #2022 revealed that storing both the vector partial sums and the derived statistics in the same VL1L2Info is not a sufficient design. Recommend that we...

  • Define a new VCNTInfo class and move the stats from VL1L2Info to this one.
  • Model the VL1L2Info/VCNTInfo classes after the existing SL1L2Info/CNTInfo ones. Having their logic differ is very confusing.
  • When doing this, make sure that any VCNTInfo statistics for which there is no data are reported as NA instead of 0. For example, when running Stat-Analysis -job aggregeate_stat for VAL1L2 -> VCNT, most of the stats should be NA. However, they're currently reported as 0 instead.
  • Currently the VL1L2Info class calls compute_stat() very frequently. Look closely at that and only compute statistics when actually needed. For example, in Stat-Analysis, when aggregating multiple VL1L2Info lines together, the stats are recomputed after each aggregation. Instead, only compute them once after aggregating all the partial sums.

@JohnHalleyGotway JohnHalleyGotway changed the title Enhance contents of VCNT line type to actually compute the bootstrap CI's in Grid-Stat and Point-Stat Enhance contents of VCNT line type to actually compute the bootstrap confidence intervals Feb 13, 2024
@JohnHalleyGotway JohnHalleyGotway self-assigned this Feb 13, 2024
@JohnHalleyGotway JohnHalleyGotway added the alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle label Oct 3, 2024
@JohnHalleyGotway JohnHalleyGotway added the alert: NEED ACCOUNT KEY Need to assign an account key to this issue label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle MET: Wind Verification priority: medium Medium Priority requestor: METplus Team METplus Development Team type: enhancement Improve something that it is currently doing
Projects
None yet
Development

No branches or pull requests

2 participants