Breaking change 0.x release: Sequence.define

[alexgorbatchev]

0.2 init no loger takes parent as first argument

0.1 version

lazy.Sequence.define 'indexBy',
  init: (@parent, @keyFn) ->
    if typeof @keyFn is 'string'
      keyStr = @keyFn
      @keyFn = (item) -> item[keyStr]
  each: (fn) ->
    for value in @parent
      fn([@keyFn(value), value])

0.2 version

lazy.Sequence.define 'indexBy',
  init: (@keyFn) ->
    if typeof @keyFn is 'string'
      keyStr = @keyFn
      @keyFn = (item) -> item[keyStr]
  each: (fn) ->
    for value in @parent
      fn([@keyFn(value), value])

Sorry about CoffeeScript but I think you get the gist.

[dtao]

You're right—I removed this because felt like it was an unnecessary requirement that just made the API less friendly. Now Lazy automatically assigns the parent so there is better consistency: indexBy("foo") means init will be called with "foo".

One thing is clear: I should start providing release notes/change lists with each release.

Do you have strong objections to this particular change? I do apologize that you had to discover this on your own; but in terms of what the interface should be, I'm hoping you agree with me that requiring parent to be the first parameter was pretty awkward?

[alexgorbatchev]

@dtao change in this case would be super awesome! I wanted to flag this change for anyone having the same problem. Personally, I do agree with you and prefer 0.2 API.

It probably makes sense to keep this issue open for some time so that others could refer to this.

[dtao]

Closing this. It's been open "for some time"—over 4 years now! ;)