From 8eee149824a05cbf09ead38eab3a33fc9f576519 Mon Sep 17 00:00:00 2001 From: David Vacca Date: Wed, 10 Apr 2019 17:28:32 -0700 Subject: [PATCH] Temporarly ignore exception when running animations Summary: Running animations sometimes fail in Android. we are ignoring those failures temporarly Reviewed By: fkgozali Differential Revision: D14884510 fbshipit-source-id: 66d6113e12b1bd67e8bcc564943b423825b4cea6 --- .../java/com/facebook/react/fabric/FabricUIManager.java | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/fabric/FabricUIManager.java b/ReactAndroid/src/main/java/com/facebook/react/fabric/FabricUIManager.java index 433f2012f65019..d9a5f289b7d183 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/fabric/FabricUIManager.java +++ b/ReactAndroid/src/main/java/com/facebook/react/fabric/FabricUIManager.java @@ -282,7 +282,12 @@ private long measure( @Override public void synchronouslyUpdateViewOnUIThread(int reactTag, ReadableMap props) { long time = SystemClock.uptimeMillis(); - scheduleMountItems(updatePropsMountItem(reactTag, props), time, 0, time, time); + try { + scheduleMountItems(updatePropsMountItem(reactTag, props), time, 0, time, time); + } catch (Exception ex) { + // ignore exceptions for now + // TODO T42943890: Fix animations in Fabric and remove this try/catch + } } /**