Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow updating gateway ACM certificate #1266

Closed
r4victor opened this issue May 23, 2024 · 2 comments
Closed

Allow updating gateway ACM certificate #1266

r4victor opened this issue May 23, 2024 · 2 comments

Comments

@r4victor
Copy link
Collaborator

#1264 added support for gateways with ACM certificates. Since ACM certificates are not renewed by dstack automatically, users should be able to update them in the gateway configuration. This should be as easy as specifying a new ARN in the configuration and running dstack apply. dstack apply should detect that the certificate has changed and update it.

Implementation details:

AWSCompute will likely get a special method for updating the ACM certificate on the gateway. It can be done by updating the listener:

response = elb_client.modify_listener(
        ListenerArn=listener_arn,
        Certificates=[
            {
                'CertificateArn': new_certificate_arn
            }
        ]
    )
@r4victor r4victor added the ux label May 23, 2024
@peterschmidt85
Copy link
Contributor

This issue is stale because it has been open for 30 days with no activity.

@peterschmidt85
Copy link
Contributor

This issue was closed because it has been inactive for 14 days since being marked as stale. Please reopen the issue if it is still relevant.

@peterschmidt85 peterschmidt85 closed this as not planned Won't fix, can't repro, duplicate, stale Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants