Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comparison between string and int when giving optional priority argument on command line #62

Closed
teamalpha5441 opened this issue May 19, 2016 · 2 comments
Labels

Comments

@teamalpha5441
Copy link

Executing ntfy with Pushover backend this way:
$ ntfy -o priority 2 send "f*ck"

yields to this error:
ERROR: Failed to send notification using pushover
Traceback (most recent call last):
File "/usr/lib/python3.5/site-packages/ntfy/init.py", line 30, in notify
module.notify(message=message, title=title, **backend_config)
File "/usr/lib/python3.5/site-packages/ntfy/backends/pushover.py", line 63, in notify
if priority <= 2 and priority >= -2:
TypeError: unorderable types: str() <= int()

https://github.com/dschep/ntfy/blob/master/ntfy/backends/pushover.py#L63

@dschep dschep added the bug label May 19, 2016
@dschep
Copy link
Owner

dschep commented May 19, 2016

Good catch, this was a contributed feature I don't use so I never ran into this bug.

@dschep dschep closed this as completed in b8c1340 May 19, 2016
@teamalpha5441
Copy link
Author

Thank you for your fast response and project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants