Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Big files on npm #40

Closed
benkaiser opened this issue Dec 20, 2015 · 4 comments
Closed

Big files on npm #40

benkaiser opened this issue Dec 20, 2015 · 4 comments
Milestone

Comments

@benkaiser
Copy link

Hello!

Thanks for the awesome project.
I am currently using your repository (as a dependency of one of my dependencies) in a project of mine, and am packaging it for multiple platforms, however the clarinet folder is 36MB on disk and it all get's automatically packaged! Would you perhaps consider .npmignoreing test/* and samples/*? As they aren't needed as part of using the library and as such doesn't make sense requiring all devs download them to their environments, and in my case, my users downloading them in a binary.

@finnp
Copy link

finnp commented Dec 29, 2015

+1 I just noticed this when looking at the playback dependencies.

@retrohacker
Copy link

It looks like an .npmignore was merged in back in May: https://github.com/dscape/clarinet/blob/master/.npmignore

But a release hasn't been cut since. Would it be possible to get a 0.11.1 out that uses the .npmignore?

@evan-king evan-king added this to the v11.0 milestone Aug 9, 2017
@kapouer
Copy link

kapouer commented Dec 19, 2017

Why closing this @evan-king ? The package in npm is still HUGE. Even in big projects i'm using, the 25MB of samples is just crazy.

@evan-king
Copy link
Collaborator

evan-king commented Dec 19, 2017

Because it's already "resolved" in the sense that the fix is in master and assigned to a ready-to-release milestone. I've been lax in actually publishing to NPM and will do so soon, but would rather not tempt Murphy during the holiday season.

(I did not originally intend to delay more than a week or so after all issues for v11.0 were closed, but it's been a rather hectic half-year, considerable portions of which saw me with limited computer access let alone time to support any incidents which arose.)

Come January 5th, feel free to shake my tree if v12 still isn't published (also finally bringing git and NPM versions back into sync, as somehow NPM got ahead). :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants