Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CMake templating #88

Closed
3 tasks done
AntoinePrv opened this issue Sep 15, 2020 · 0 comments · Fixed by #172
Closed
3 tasks done

Remove CMake templating #88

AntoinePrv opened this issue Sep 15, 2020 · 0 comments · Fixed by #172
Labels
what/build-system 🔧 Toolset for building and testing

Comments

@AntoinePrv
Copy link
Member

AntoinePrv commented Sep 15, 2020

Describe the problem or improvement suggested

Templating steup.py and doc/config.py with CMake makes it laborious to add new files and increase the barriers to contributing.

Describe the solution you would like

  • Add the authors, version,... in files under about/ and read them separately from Python and CMake.
  • Edit setup.py to find the shared library somewhere else?
  • Change the installation instructions if needed

Describe alternatives you have considered

Move to scikit-build #37

Additional context

@AntoinePrv AntoinePrv added the type/enhancement 🚀 New feature or request label Sep 15, 2020
@AntoinePrv AntoinePrv added what/build-system 🔧 Toolset for building and testing and removed type/enhancement 🚀 New feature or request labels Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
what/build-system 🔧 Toolset for building and testing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant