-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Issue #3336148: Add support for forms #247
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
e1e9a12
feat: Issue #3336148: Add support for forms
vloss3 19d5b8f
LDP-2492: Remove unnecessary if
vloss3 c28d26c
LDP-2492: Improve redirect code
vloss3 784797f
LDP-2492: Improve internal redirect code
vloss3 631bab2
LDP-2492: Revert redirect code
vloss3 36af30d
LDP-2492: Improve code and use page middleware
vloss3 83ccb91
LDP-2492: Add server middleware and error handling
vloss3 9c27504
LDP-2492: Move middleware to module
vloss3 7ab5436
LDP-2492: Include error message commit
vloss3 6f1075f
LDP-2492: Add imports
vloss3 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
<template> | ||
<form :formId="formId" :method="method" v-bind="attributes" :action="useRoute().fullPath" class="drupal-form"> | ||
<slot><div v-html="content" /></slot> | ||
</form> | ||
</template> | ||
|
||
<script setup lang="ts"> | ||
const props = defineProps<{ | ||
formId: String, | ||
attributes: Object, | ||
method: String, | ||
content?: String, | ||
}>() | ||
</script> |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
import { defineEventHandler, readFormData } from 'h3' | ||
import { getDrupalBaseUrl } from '../../composables/useDrupalCe/server' | ||
import { useRuntimeConfig } from '#imports' | ||
|
||
export default defineEventHandler(async (event) => { | ||
const { ceApiEndpoint } = useRuntimeConfig().public.drupalCe | ||
|
||
if (event.node.req.method === 'POST') { | ||
const formData = await readFormData(event) | ||
|
||
if (formData) { | ||
const targetUrl = event.node.req.url | ||
const response = await $fetch.raw(getDrupalBaseUrl() + ceApiEndpoint + targetUrl, { | ||
method: 'POST', | ||
body: formData, | ||
}).catch((error) => { | ||
event.context.drupalCeCustomPageResponse = { | ||
error: { | ||
data: error, | ||
statusCode: error.statusCode || 400, | ||
message: error.message || 'Error when POSTing form data (drupalFormHandler).', | ||
}, | ||
} | ||
}) | ||
|
||
if (response) { | ||
event.context.drupalCeCustomPageResponse = { | ||
_data: response._data, | ||
headers: Object.fromEntries(response.headers.entries()), | ||
} | ||
} | ||
} else { | ||
throw createError({ | ||
statusCode: 400, | ||
statusMessage: 'Bad Request', | ||
message: 'POST requests without form data are not supported (drupalFormHandler).', | ||
}) | ||
} | ||
} | ||
}) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still not 100% convinced we need serverResponse for hydrating things, since page should be already hydrated. But let's merge and re-check things once we have it merged and working.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and ensured it's not double-hydrated. maybe code could be nicer, but that seems all good!