-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HPA doesn't work with operator v0.0.5 #160
Comments
@himanshug in order to fix this i see this option as the simplest check, the logic for checkin if hpa spec exists can be checked at multiple places ex: inside the sdkCreateUpdate method, or in the main handler func(). Since as of now we arn't forcing any other update apart from replica this felt simple though this requires the func() obj to be tweaked to accept nodeSpec too. ie is Let me know if you have a better approach.
|
hmmm... my first thought is, I was skeptical of introducing that behavior, one simple option is to revert #115 and assume that user is not expected to manually change things setup by operator. It seems like complexity for not a major benefit. |
@himanshug |
Using an HPA with operator v0.0.5 doesn't work because the operator immediately tries to reconcile the deployment/statefulset back to the original replica count. Most likely due to PR #115
The HPA works as expected with operator v0.0.4.
Sample HPA spec from druid cluster.yaml:
The text was updated successfully, but these errors were encountered: