Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated imp module with importlib #295

Closed
hugovk opened this issue Apr 29, 2023 · 2 comments
Closed

Replace deprecated imp module with importlib #295

hugovk opened this issue Apr 29, 2023 · 2 comments
Labels

Comments

@hugovk
Copy link

hugovk commented Apr 29, 2023

Describe the bug

This project uses the imp module which has been deprecated since Python 3.4 and removed in 3.12:

Python 3.12 is set for release on 2023-10-02 and this library is one of the top 5,000 most-downloaded from PyPI.

Please could you upgrade to use importlib? The imp docs have suggestions on what to use to replace each function and constant.

To Reproduce

git grep "\bimp\b"

Expected Behavior

Works on Python 3.12.

Actual Behavior

Will fail due to removed imp module.

Additional context
Add any other context about the problem here.

import imp # pylint: disable=deprecated-module

api = imp.load_source('api', args.api[0]).api # pylint: disable=redefined-outer-name

backend_module = imp.load_source('user_backend', args.backend)

@hugovk hugovk added the bug label Apr 29, 2023
@greg-db
Copy link
Contributor

greg-db commented May 1, 2023

Thanks! I'll ask the team to update this.

@greg-db
Copy link
Contributor

greg-db commented Jul 20, 2023

The use of imp has been replaced with importlib in #307.

@greg-db greg-db closed this as completed Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants