Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove closed pull requests more intelligently #43

Open
Tathanen opened this issue Jul 18, 2016 · 2 comments
Open

Remove closed pull requests more intelligently #43

Tathanen opened this issue Jul 18, 2016 · 2 comments
Assignees

Comments

@Tathanen
Copy link
Contributor

Right now pull requests are removed from the repo list after two days of inactivity, because we have no way of knowing if a pull request has been closed instead of merged. PR-closing doesn't trigger a build, and our data comes exclusively from a feed of drone builds.

The only conceivable solution is to hit the Github API to check on PR status on regular intervals, but it feels like that'd add so much overhead in network hits and up-front configuration that it's not really worth it.

Keeping this logged since it is indeed an issue, whether we decide to move on it this way, some other way, or no way.

@Tathanen
Copy link
Contributor Author

Will be making a bit of an improvement via #44, but it's still not the best solution. Keeping it separate from this issue since it doesn't really solve the problem, just makes the present approach more flexible.

@Tathanen Tathanen changed the title Remove closed pull requests in a more timely manner Remove closed pull requests more intelligently Jul 24, 2016
@Tathanen
Copy link
Contributor Author

Tathanen commented Aug 4, 2016

@bradrydzewski out of curiosity, would it be reasonable for drone to watch for a pull request's "close" and "reopen" events, and do.. something? Maybe deliver a build with a custom status to communicate the change of state to any clients (ala the wall) consuming the drone service? Nothing is actually getting built so I know it might be a little weird, but maybe there's still value as some sort of helper service. Perhaps even divorced from the user/feed route, as a separate events/feed route, or an optional flag to pass to user/feed to request those additional events.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant