Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support TLS 1.3 #310

Closed
r3pek opened this issue Nov 26, 2020 · 10 comments
Closed

Support TLS 1.3 #310

r3pek opened this issue Nov 26, 2020 · 10 comments

Comments

@r3pek
Copy link

r3pek commented Nov 26, 2020

Pretty much the same as drone-plugins/drone-matrix#17

Right now, when connection to a TLS 1.3 only server, we get this when cloning the repo:
fatal: unable to access 'https://************.org/********/docker-ideaspacevr.git/': error:1400442E:SSL routines:CONNECT_CR_SRVR_HELLO:tlsv1 alert protocol version

@ashwilliams1
Copy link

This plugin is a wrapper around docker, which means support for TLS 1.3 needs to be implemented at the docker level. It looks like implementing TLS 1.3 is on the docker roadmap. See moby/moby#40495

@r3pek
Copy link
Author

r3pek commented Nov 26, 2020

@ashwilliams1 the error is actually is in the git fetch origin +refs/heads/master command, so, i don't think it's really a "docker" problem.

@ashwilliams1
Copy link

not sure I follow, since this plugin does not perform a git clone

@r3pek
Copy link
Author

r3pek commented Nov 26, 2020

Hummmm what does then? on drone i mean. It clones the original repo and (this plugin) builds a docker image from it. Was under the impression it was this plugin that did it.

kind: pipeline
name: build-docker-image

steps:
    -   name: build-docker-image
        image: plugins/docker
        settings:
            repo: r3pek/ideaspacevr
            username:
                from_secret: docker_username
            password:
                from_secret: docker_password
            when:
                branch: master
                event: push

^^ this turns into this:

image

@ashwilliams1
Copy link

the clone step is handled by the clone plugin. See https://github.com/drone/drone-git.

@r3pek
Copy link
Author

r3pek commented Nov 26, 2020

the clone step is handled by the clone plugin. See https://github.com/drone/drone-git.

Ah! I'll open a but there then. thx for the info

EDIT: Can't open since it doesn't have "Issues" activated. Any info on how to proceed?

@tboerger
Copy link

Create a PR ;)

@r3pek
Copy link
Author

r3pek commented Nov 26, 2020

Create a PR ;)

hahahaha wouldn't even know where to start :D not a go programmer myself :(

@tboerger
Copy link

The git plugin is not even written in Go ;)

@r3pek
Copy link
Author

r3pek commented Nov 27, 2020

@tboerger my bad..... didn't even check 😇
PR created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants