Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add new field description in hertzbeat tag detail #1489

Merged
merged 2 commits into from
Jan 15, 2024

Conversation

GEM0816g
Copy link
Contributor

…d , edit tag description in webui

What's changed?

add new field description in hertzbeat tag detail and can add,edit tag description in webui

Checklist

  • I hereby agree to the terms of the HertzBeat CLA
  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@tomsun28 tomsun28 requested a review from TJxiaobao January 15, 2024 14:11
@tomsun28 tomsun28 added enhancement New feature or request good first pull request Good for newcomers new feature labels Jan 15, 2024
@tomsun28 tomsun28 added this to the 1.4.5 milestone Jan 15, 2024
@tomsun28
Copy link
Contributor

👍👍LGTM!hi, there is an eslint error in webapp, you can run yarn lint:ts to auto fix it.

Copy link
Contributor

@TJxiaobao TJxiaobao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tomsun28
Copy link
Contributor

@all-contributors please add @GEM0816g for code

@tomsun28 tomsun28 linked an issue Jan 15, 2024 that may be closed by this pull request
2 tasks
@tomsun28 tomsun28 merged commit 0370cac into apache:master Jan 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first pull request Good for newcomers new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] <add new field description in hertzbeat tag detail>
3 participants