Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Contributor] 컨트리뷰터 화면 이동 방법 추가 #59

Merged
merged 7 commits into from
Jul 20, 2023
Merged

[Contributor] 컨트리뷰터 화면 이동 방법 추가 #59

merged 7 commits into from
Jul 20, 2023

Conversation

wisemuji
Copy link
Member

@wisemuji wisemuji commented Jul 20, 2023 •
edited
Loading

Issue

Overview (Required)

  • Home에서 Contirbutor로 이동할 수 있도록 구현
  • Contirbutor로 Home으로 이동할 수 있도록 구현(뒤로가기)
  • 현재는 MainScreen(root)에서 Scaffold를 통해 top padding, bottom bar를 제공하는 형태라 컨트리뷰터 화면에서는 해당 뷰가 노출되지 않도록 분기 처리
    • compose-samples/Jetsnack에서는 root view에서 Scaffold로 호스팅하는 것이 아닌, 각 탭별 Scaffold를 따로 구현했더라고요. (참고)
    • 위 방법이 더 좋다고 생각하신다면 의견 부탁드립니다.

Links

Screenshot

@wisemuji wisemuji added the enhancement New feature or request label Jul 20, 2023
@wisemuji wisemuji requested a review from laco-dev July 20, 2023 09:57
@wisemuji wisemuji self-assigned this Jul 20, 2023
laco-dev
laco-dev reviewed Jul 20, 2023
View reviewed changes
.../contributor/src/main/java/com/droidknights/app2023/feature/contributor/ContributorScreen.kt Show resolved Hide resolved
feature/main/src/main/java/com/droidknights/app2023/feature/main/MainScreen.kt Outdated
Comment on lines 41 to 44
val showBottomBar = when (navBackStackEntry?.destination?.route) {
ContributorRoute.route -> false
else -> true
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

navigator.showBottomBar 로 만들어주세요

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

반영했습니다. 71efaea

feature/home/src/main/java/com/droidknights/app2023/feature/home/navigation/HomeNavigation.kt Outdated Show resolved Hide resolved
feature/main/src/main/java/com/droidknights/app2023/feature/main/MainScreen.kt Outdated Show resolved Hide resolved
@wisemuji wisemuji requested a review from laco-dev July 20, 2023 12:46
laco-dev
laco-dev approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@laco-dev laco-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이후 작업에서 네비게이션 관련 수정이 조금 있어서 병합 해주시면 반영해서 PR 올리겠습니다

@wisemuji wisemuji merged commit fc1b4df into droidknights:main Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laco-dev laco-dev laco-dev approved these changes

Assignees

@wisemuji wisemuji

Labels
2023 enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Contributor] 컨트리뷰터 이동 방법 추가
3 participants
@wisemuji @laco-dev @taehwandev