#1 detekt 적용, actions에 적용적용 #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laco-dev
reviewed
Jun 8, 2023
Comment on lines
+52
to
+53
| # plugin | ||
| verify-detektPlugin = { module = "io.gitlab.arturbosch.detekt:detekt-gradle-plugin", version.ref = "detekt" } |
There was a problem hiding this comment.
libraries 바로밑에 모아져있는 android-gradlePlugin kotlin-gradlePlugin 플러그인도 #plugin 아래로 옮겨야 할 것 같아요
There was a problem hiding this comment.
근데 둘다 플러그인용이 있고, 이름만 플러그인도 있어서 애매하네요. 저도 정리하다가
There was a problem hiding this comment.
만들면서 중간에 정리할 일이 몇번 있을 듯 하니 그때 맞춰보면 될 것 같습니다 👀
build-logic/src/main/kotlin/droidknights.verify.detekt.gradle.kts
Outdated
Show resolved
Hide resolved
| buildUponDefaultConfig = true // preconfigure defaults | ||
| allRules = false // activate all available (even unstable) rules. | ||
| parallel = true | ||
| config.setFrom(listOf(file("$rootDir/config/detekt/detekt.yml"))) // point to your custom config defining rules to run, overwriting default behavior |
There was a problem hiding this comment.
플러그인을 설치하기는 했는데, 원래 maxline rule이 주석에도 잡히나요!?
There was a problem hiding this comment.
네 요거하면 max line도 잡히긴 한데 저렇게 밑줄 그어지나요?
There was a problem hiding this comment.
네 변수로 나눠달라는 경고보다는 라인이 길다라는 경고가 먼저 들어오더라구요.
안드로이드 스튜디오에 있는 플러그인 문제인지 실제 task에서는 안잡힙니다
There was a problem hiding this comment.
안스 설정에서 configuration file 등록하니 task와 동일하게 잡네요
Co-authored-by: Youngjik Yoon <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.