From 88a8380330577f976e6c38cca07712dfaecd7fa4 Mon Sep 17 00:00:00 2001 From: JeonK1 Date: Tue, 28 May 2024 20:03:04 +0900 Subject: [PATCH 01/11] =?UTF-8?q?feat=20:=20HomeScreen=20design=20?= =?UTF-8?q?=EC=B5=9C=EC=8B=A0=ED=99=94?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../app/feature/home/component/ContributorCard.kt | 4 ++-- .../droidknights/app/feature/home/component/SessionCard.kt | 2 +- .../droidknights/app/feature/home/component/SponsorCard.kt | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/feature/home/src/main/java/com/droidknights/app/feature/home/component/ContributorCard.kt b/feature/home/src/main/java/com/droidknights/app/feature/home/component/ContributorCard.kt index 5568a2eb..d5135b9d 100644 --- a/feature/home/src/main/java/com/droidknights/app/feature/home/component/ContributorCard.kt +++ b/feature/home/src/main/java/com/droidknights/app/feature/home/component/ContributorCard.kt @@ -52,9 +52,9 @@ internal fun ContributorCard( Text( text = stringResource(id = R.string.contributor_card_description), - style = KnightsTheme.typography.titleSmallR, + style = KnightsTheme.typography.titleSmallM140, color = Green03, - modifier = Modifier.padding(top = 6.dp), + modifier = Modifier.padding(top = 6.dp, start = 3.dp), ) } } diff --git a/feature/home/src/main/java/com/droidknights/app/feature/home/component/SessionCard.kt b/feature/home/src/main/java/com/droidknights/app/feature/home/component/SessionCard.kt index 151f70d3..be717895 100644 --- a/feature/home/src/main/java/com/droidknights/app/feature/home/component/SessionCard.kt +++ b/feature/home/src/main/java/com/droidknights/app/feature/home/component/SessionCard.kt @@ -55,7 +55,7 @@ internal fun SessionCard( private fun SessionCardCaption() { Box( modifier = Modifier - .background(Graphite, RoundedCornerShape(32.dp)) + .background(Graphite, RoundedCornerShape(10.dp)) .padding(horizontal = 12.dp, vertical = 2.dp) ) { Text( diff --git a/feature/home/src/main/java/com/droidknights/app/feature/home/component/SponsorCard.kt b/feature/home/src/main/java/com/droidknights/app/feature/home/component/SponsorCard.kt index 2574d38d..b1a24f9b 100644 --- a/feature/home/src/main/java/com/droidknights/app/feature/home/component/SponsorCard.kt +++ b/feature/home/src/main/java/com/droidknights/app/feature/home/component/SponsorCard.kt @@ -73,7 +73,7 @@ private fun SponsorCardContents(uiState: SponsorsUiState.Sponsors) { uiState.goldCount, uiState.silverCount ), - style = KnightsTheme.typography.titleSmallR, + style = KnightsTheme.typography.titleSmallM140, color = DuskGray, modifier = Modifier.padding(top = 8.dp), ) @@ -117,7 +117,7 @@ private fun SponsorGroupRow( LazyRow( modifier = modifier, - horizontalArrangement = Arrangement.spacedBy(space = 22.dp), + horizontalArrangement = Arrangement.spacedBy(space = 24.dp), userScrollEnabled = false ) { items( From 700cdb2569f36d3f86d7bd1a20ab9b44ff596897 Mon Sep 17 00:00:00 2001 From: JeonK1 Date: Tue, 28 May 2024 20:57:19 +0900 Subject: [PATCH 02/11] =?UTF-8?q?feat=20:=20SettingScreen=20design=20?= =?UTF-8?q?=EC=B5=9C=EC=8B=A0=ED=99=94?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../com/droidknights/app/feature/setting/SettingScreen.kt | 4 +++- .../app/feature/setting/component/OpenSourceCard.kt | 6 +++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/feature/setting/src/main/java/com/droidknights/app/feature/setting/SettingScreen.kt b/feature/setting/src/main/java/com/droidknights/app/feature/setting/SettingScreen.kt index 81ae84f2..e288d154 100644 --- a/feature/setting/src/main/java/com/droidknights/app/feature/setting/SettingScreen.kt +++ b/feature/setting/src/main/java/com/droidknights/app/feature/setting/SettingScreen.kt @@ -64,6 +64,7 @@ private fun LightDarkThemeCard( Column { Text( text = stringResource(id = R.string.setting), + color = MaterialTheme.colorScheme.onPrimaryContainer, style = KnightsTheme.typography.headlineSmallBL, modifier = Modifier.padding(top = 24.dp, start = 24.dp), ) @@ -71,7 +72,7 @@ private fun LightDarkThemeCard( Row( modifier = Modifier - .padding(horizontal = 8.dp) + .padding(start = 16.dp, end = 16.dp, bottom = 24.dp) .fillMaxWidth(), horizontalArrangement = Arrangement.spacedBy(8.dp), ) { @@ -122,6 +123,7 @@ private fun ThemeCard( Text( text = stringResource(id = titleRes), modifier = Modifier.padding(top = 16.dp, bottom = 8.dp), + color = MaterialTheme.colorScheme.onPrimaryContainer, style = KnightsTheme.typography.titleSmallM140, ) diff --git a/feature/setting/src/main/java/com/droidknights/app/feature/setting/component/OpenSourceCard.kt b/feature/setting/src/main/java/com/droidknights/app/feature/setting/component/OpenSourceCard.kt index 242b6315..f87ab882 100644 --- a/feature/setting/src/main/java/com/droidknights/app/feature/setting/component/OpenSourceCard.kt +++ b/feature/setting/src/main/java/com/droidknights/app/feature/setting/component/OpenSourceCard.kt @@ -12,12 +12,14 @@ import androidx.compose.runtime.Composable import androidx.compose.runtime.CompositionLocalProvider import androidx.compose.ui.Alignment import androidx.compose.ui.Modifier +import androidx.compose.ui.graphics.Color import androidx.compose.ui.platform.LocalContext import androidx.compose.ui.res.painterResource import androidx.compose.ui.res.stringResource import androidx.compose.ui.tooling.preview.Preview import androidx.compose.ui.unit.dp import com.droidknights.app.core.designsystem.component.KnightsCard +import com.droidknights.app.core.designsystem.theme.Graphite import com.droidknights.app.core.designsystem.theme.KnightsTheme import com.droidknights.app.feature.setting.R import com.google.android.gms.oss.licenses.OssLicensesMenuActivity @@ -33,6 +35,7 @@ internal fun OpenSourceCard( CompositionLocalProvider(LocalContentColor provides MaterialTheme.colorScheme.onPrimaryContainer) { KnightsCard( modifier = modifier, + color = Graphite, onClick = { context.startActivity(Intent(context, OssLicensesMenuActivity::class.java)) } @@ -41,6 +44,7 @@ internal fun OpenSourceCard( Text( text = titleText, style = KnightsTheme.typography.headlineSmallBL, + color = Color.White, modifier = Modifier .padding(top = 24.dp, start = 24.dp) ) @@ -63,4 +67,4 @@ internal fun OpenSourceCard( @Composable private fun PreviewOpenSourceCard() { OpenSourceCard() -} \ No newline at end of file +} From 85d101e5641dfcec2c7d01de465418ec74374be2 Mon Sep 17 00:00:00 2001 From: JeonK1 Date: Tue, 28 May 2024 21:18:24 +0900 Subject: [PATCH 03/11] =?UTF-8?q?feat=20:=20contributor=20design=20?= =?UTF-8?q?=EC=B5=9C=EC=8B=A0=ED=99=94?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../com/droidknights/app/core/designsystem/component/Chip.kt | 2 +- .../droidknights/app/feature/contributor/ContributorScreen.kt | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/core/designsystem/src/main/java/com/droidknights/app/core/designsystem/component/Chip.kt b/core/designsystem/src/main/java/com/droidknights/app/core/designsystem/component/Chip.kt index e6afe777..84d18806 100644 --- a/core/designsystem/src/main/java/com/droidknights/app/core/designsystem/component/Chip.kt +++ b/core/designsystem/src/main/java/com/droidknights/app/core/designsystem/component/Chip.kt @@ -34,7 +34,7 @@ fun TextChip( shape = RoundedCornerShape(10.dp), color = containerColor, ) { - ProvideTextStyle(KnightsTheme.typography.labelMediumR) { + ProvideTextStyle(KnightsTheme.typography.labelSmallM) { Text(text = text, color = labelColor, modifier = Modifier.padding(TextChipPadding)) } } diff --git a/feature/contributor/src/main/java/com/droidknights/app/feature/contributor/ContributorScreen.kt b/feature/contributor/src/main/java/com/droidknights/app/feature/contributor/ContributorScreen.kt index eb896f08..b6c6f751 100644 --- a/feature/contributor/src/main/java/com/droidknights/app/feature/contributor/ContributorScreen.kt +++ b/feature/contributor/src/main/java/com/droidknights/app/feature/contributor/ContributorScreen.kt @@ -39,6 +39,7 @@ import com.droidknights.app.core.designsystem.component.KnightsCard import com.droidknights.app.core.designsystem.component.KnightsTopAppBar import com.droidknights.app.core.designsystem.component.NetworkImage import com.droidknights.app.core.designsystem.component.TextChip +import com.droidknights.app.core.designsystem.component.TopAppBarNavigationType import com.droidknights.app.core.designsystem.res.rememberPainterResource import com.droidknights.app.core.designsystem.theme.Black import com.droidknights.app.core.designsystem.theme.KnightsTheme @@ -106,6 +107,7 @@ private fun ContributorTopAppBar( titleRes = R.string.contributor_top_title, navigationIconContentDescription = null, modifier = Modifier.statusBarsPadding(), + navigationType = TopAppBarNavigationType.Close, onNavigationClick = onBackClick, containerColor = containerColor, ) From 96f13a98253b200cbe5e38701578df08a4e0203b Mon Sep 17 00:00:00 2001 From: JeonK1 Date: Thu, 30 May 2024 21:51:41 +0900 Subject: [PATCH 04/11] =?UTF-8?q?feat=20:=20sessionScreen=20design=20?= =?UTF-8?q?=EC=B5=9C=EC=8B=A0=ED=99=94?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../com/droidknights/app/core/designsystem/theme/Color.kt | 2 +- .../com/droidknights/app/feature/session/SessionScreen.kt | 6 +++--- .../app/feature/session/component/SessionTopAppBar.kt | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/core/designsystem/src/main/java/com/droidknights/app/core/designsystem/theme/Color.kt b/core/designsystem/src/main/java/com/droidknights/app/core/designsystem/theme/Color.kt index 8047d864..4a65a612 100644 --- a/core/designsystem/src/main/java/com/droidknights/app/core/designsystem/theme/Color.kt +++ b/core/designsystem/src/main/java/com/droidknights/app/core/designsystem/theme/Color.kt @@ -32,7 +32,7 @@ val Green04 = Color(0xFF386524) val Yellow01 = Color(0xFFF2E800) val Yellow02 = Color(0xFFE8ED00) val Yellow03 = Color(0xFFBEED00) -val Yellow03A40 = Color(0x66BEED00) +val Yellow03A40 = Color(0x66A1ED00) val Yellow04 = Color(0xFF465703) val Yellow05 = Color(0xFF222B00) diff --git a/feature/session/src/main/java/com/droidknights/app/feature/session/SessionScreen.kt b/feature/session/src/main/java/com/droidknights/app/feature/session/SessionScreen.kt index c48653cc..befc1e92 100644 --- a/feature/session/src/main/java/com/droidknights/app/feature/session/SessionScreen.kt +++ b/feature/session/src/main/java/com/droidknights/app/feature/session/SessionScreen.kt @@ -78,7 +78,7 @@ private fun SessionContent( LazyColumn( modifier = modifier, state = sessionState.listState, - contentPadding = PaddingValues(horizontal = 8.dp, vertical = 12.dp), + contentPadding = PaddingValues(horizontal = 8.dp), verticalArrangement = Arrangement.spacedBy(16.dp), ) { sessionState.groups.forEachIndexed { index, group -> @@ -97,8 +97,8 @@ private fun SessionContent( } } -private val SessionTopSpace = 4.dp -private val SessionGroupSpace = 16.dp +private val SessionTopSpace = 16.dp +private val SessionGroupSpace = 84.dp private fun LazyListScope.sessionItems( room: Room, diff --git a/feature/session/src/main/java/com/droidknights/app/feature/session/component/SessionTopAppBar.kt b/feature/session/src/main/java/com/droidknights/app/feature/session/component/SessionTopAppBar.kt index bb2d35dc..64f5ee84 100644 --- a/feature/session/src/main/java/com/droidknights/app/feature/session/component/SessionTopAppBar.kt +++ b/feature/session/src/main/java/com/droidknights/app/feature/session/component/SessionTopAppBar.kt @@ -142,7 +142,7 @@ private fun TabIndicator(height: Dp, modifier: Modifier) { modifier = modifier .height(height * 2) .offset { IntOffset(0, height.roundToPx()) } - .background(brush, RoundedCornerShape(8.dp)) + .background(brush, RoundedCornerShape(100.dp, 100.dp, 0.dp, 0.dp)) ) } From 91ad5f189d00616d97454be25887c60c60a94b4e Mon Sep 17 00:00:00 2001 From: JeonK1 Date: Thu, 30 May 2024 22:08:42 +0900 Subject: [PATCH 05/11] =?UTF-8?q?feat=20:=20SessionDetailScreen=20design?= =?UTF-8?q?=20=EC=B5=9C=EC=8B=A0=ED=99=94?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../app/feature/session/SessionDetailScreen.kt | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/feature/session/src/main/java/com/droidknights/app/feature/session/SessionDetailScreen.kt b/feature/session/src/main/java/com/droidknights/app/feature/session/SessionDetailScreen.kt index a70e9610..d113fbd2 100644 --- a/feature/session/src/main/java/com/droidknights/app/feature/session/SessionDetailScreen.kt +++ b/feature/session/src/main/java/com/droidknights/app/feature/session/SessionDetailScreen.kt @@ -30,6 +30,7 @@ import androidx.compose.ui.Alignment import androidx.compose.ui.Modifier import androidx.compose.ui.draw.clip import androidx.compose.ui.platform.LocalContext +import androidx.compose.ui.res.colorResource import androidx.compose.ui.res.painterResource import androidx.compose.ui.res.stringResource import androidx.compose.ui.tooling.preview.Preview @@ -43,8 +44,10 @@ import com.droidknights.app.core.designsystem.component.NetworkImage import com.droidknights.app.core.designsystem.component.TextChip import com.droidknights.app.core.designsystem.component.TopAppBarNavigationType import com.droidknights.app.core.designsystem.theme.DarkGray +import com.droidknights.app.core.designsystem.theme.Gray import com.droidknights.app.core.designsystem.theme.KnightsTheme import com.droidknights.app.core.designsystem.theme.LightGray +import com.droidknights.app.core.designsystem.theme.Purple01 import com.droidknights.app.core.model.Room import com.droidknights.app.core.model.Session import com.droidknights.app.core.model.Speaker @@ -154,7 +157,7 @@ private fun SessionDetailContent(session: Session) { .padding(horizontal = 16.dp) ) { SessionDetailTitle(title = session.title, modifier = Modifier.padding(top = 8.dp)) - Spacer(modifier = Modifier.height(8.dp)) + Spacer(modifier = Modifier.height(12.dp)) SessionChips(session = session) if (session.content.isNotEmpty()) { @@ -203,7 +206,7 @@ private fun SessionDetailTitle( modifier: Modifier = Modifier, ) { Text( - modifier = modifier.padding(end = 64.dp), + modifier = modifier.padding(end = 58.dp), text = title, style = KnightsTheme.typography.headlineMediumB, color = MaterialTheme.colorScheme.onSecondaryContainer, @@ -272,7 +275,8 @@ private fun BookmarkToggleButton( } else { painterResource(id = R.drawable.ic_session_bookmark) }, - contentDescription = null + contentDescription = null, + tint = if (bookmarked) Purple01 else Gray ) } } From 98375377a686dadc256673ff5289954001836dd0 Mon Sep 17 00:00:00 2001 From: JeonK1 Date: Thu, 30 May 2024 22:37:01 +0900 Subject: [PATCH 06/11] =?UTF-8?q?feat=20:=20=EB=B6=81=EB=A7=88=ED=81=AC=20?= =?UTF-8?q?Chip=20=EC=83=9D=EC=84=B1=20=EB=B0=8F=20=EC=B6=94=EA=B0=80?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../designsystem/component/IconTextChip.kt | 72 +++++++++++++++++++ .../component/{Chip.kt => TextChip.kt} | 0 .../app/core/designsystem/theme/Color.kt | 1 + .../feature/session/component/SessionCard.kt | 13 ++++ .../session/src/main/res/values/strings.xml | 2 + 5 files changed, 88 insertions(+) create mode 100644 core/designsystem/src/main/java/com/droidknights/app/core/designsystem/component/IconTextChip.kt rename core/designsystem/src/main/java/com/droidknights/app/core/designsystem/component/{Chip.kt => TextChip.kt} (100%) diff --git a/core/designsystem/src/main/java/com/droidknights/app/core/designsystem/component/IconTextChip.kt b/core/designsystem/src/main/java/com/droidknights/app/core/designsystem/component/IconTextChip.kt new file mode 100644 index 00000000..38f96fd0 --- /dev/null +++ b/core/designsystem/src/main/java/com/droidknights/app/core/designsystem/component/IconTextChip.kt @@ -0,0 +1,72 @@ +package com.droidknights.app.core.designsystem.component + +import androidx.compose.foundation.layout.Arrangement +import androidx.compose.foundation.layout.Row +import androidx.compose.foundation.layout.height +import androidx.compose.foundation.layout.padding +import androidx.compose.foundation.layout.width +import androidx.compose.foundation.shape.RoundedCornerShape +import androidx.compose.material3.Icon +import androidx.compose.material3.MaterialTheme +import androidx.compose.material3.ProvideTextStyle +import androidx.compose.material3.Surface +import androidx.compose.material3.Text +import androidx.compose.runtime.Composable +import androidx.compose.ui.Alignment +import androidx.compose.ui.Modifier +import androidx.compose.ui.graphics.Color +import androidx.compose.ui.graphics.painter.Painter +import androidx.compose.ui.res.painterResource +import androidx.compose.ui.tooling.preview.Preview +import androidx.compose.ui.unit.dp +import com.droidknights.app.core.designsystem.theme.DarkGray +import com.droidknights.app.core.designsystem.theme.KnightsTheme +import com.droidknights.app.core.designsystem.theme.LightGray + +@Composable +fun IconTextChip( + text: String, + containerColor: Color, + labelColor: Color, + iconPainter: Painter, + iconTint: Color, + modifier: Modifier = Modifier, +) { + Surface( + modifier = modifier, + shape = RoundedCornerShape(10.dp), + color = containerColor, + ) { + Row( + modifier = modifier.padding(start = 4.dp, end = 10.dp), + verticalAlignment = Alignment.CenterVertically, + horizontalArrangement = Arrangement.Start + ) { + Icon( + modifier = modifier + .width(20.dp) + .height(20.dp), + painter = iconPainter, + contentDescription = null, + tint = iconTint + ) + ProvideTextStyle(KnightsTheme.typography.labelSmallM) { + Text(text = text, color = labelColor, modifier = Modifier.padding(top = 2.dp, bottom = 2.dp)) + } + } + } +} + +@Preview +@Composable +private fun IconTextChipPreview() { + MaterialTheme { + IconTextChip( + "북마크", + containerColor = DarkGray, + labelColor = LightGray, + iconPainter = painterResource(id = androidx.appcompat.R.drawable.abc_btn_radio_material), + iconTint = Color.Green + ) + } +} diff --git a/core/designsystem/src/main/java/com/droidknights/app/core/designsystem/component/Chip.kt b/core/designsystem/src/main/java/com/droidknights/app/core/designsystem/component/TextChip.kt similarity index 100% rename from core/designsystem/src/main/java/com/droidknights/app/core/designsystem/component/Chip.kt rename to core/designsystem/src/main/java/com/droidknights/app/core/designsystem/component/TextChip.kt diff --git a/core/designsystem/src/main/java/com/droidknights/app/core/designsystem/theme/Color.kt b/core/designsystem/src/main/java/com/droidknights/app/core/designsystem/theme/Color.kt index 4a65a612..1f9bab4b 100644 --- a/core/designsystem/src/main/java/com/droidknights/app/core/designsystem/theme/Color.kt +++ b/core/designsystem/src/main/java/com/droidknights/app/core/designsystem/theme/Color.kt @@ -13,6 +13,7 @@ val Black = Color(0xFF000000) val Graphite = Color(0xFF292929) val Purple01 = Color(0xFFB469FF) +val Purple01A30 = Color(0x4DB469FF) val Mint01 = Color(0xFF7BFAF2) val Neon01 = Color(0xFF49F300) diff --git a/feature/session/src/main/java/com/droidknights/app/feature/session/component/SessionCard.kt b/feature/session/src/main/java/com/droidknights/app/feature/session/component/SessionCard.kt index afd69a48..d156b723 100644 --- a/feature/session/src/main/java/com/droidknights/app/feature/session/component/SessionCard.kt +++ b/feature/session/src/main/java/com/droidknights/app/feature/session/component/SessionCard.kt @@ -22,12 +22,15 @@ import androidx.compose.ui.res.painterResource import androidx.compose.ui.res.stringResource import androidx.compose.ui.tooling.preview.Preview import androidx.compose.ui.unit.dp +import com.droidknights.app.core.designsystem.component.IconTextChip import com.droidknights.app.core.designsystem.component.KnightsCard import com.droidknights.app.core.designsystem.component.NetworkImage import com.droidknights.app.core.designsystem.component.TextChip import com.droidknights.app.core.designsystem.theme.DarkGray import com.droidknights.app.core.designsystem.theme.KnightsTheme import com.droidknights.app.core.designsystem.theme.LightGray +import com.droidknights.app.core.designsystem.theme.Purple01 +import com.droidknights.app.core.designsystem.theme.Purple01A30 import com.droidknights.app.core.model.Room import com.droidknights.app.core.model.Session import com.droidknights.app.core.model.Speaker @@ -131,6 +134,16 @@ private fun SessionTrackInfo( TrackChip(room = session.room) Spacer(modifier = Modifier.width(8.dp)) TimeChip(dateTime = session.startTime) + if (session.isBookmarked) { + Spacer(modifier = Modifier.width(8.dp)) + IconTextChip( + text = stringResource(id = R.string.bookmark), + containerColor = Purple01A30, + labelColor = Purple01, + iconPainter = painterResource(id = R.drawable.ic_session_bookmark_filled), + iconTint = Purple01 + ) + } } } diff --git a/feature/session/src/main/res/values/strings.xml b/feature/session/src/main/res/values/strings.xml index 502174cd..963032f9 100644 --- a/feature/session/src/main/res/values/strings.xml +++ b/feature/session/src/main/res/values/strings.xml @@ -10,4 +10,6 @@ 북마크에 저장했습니다. 시간표를 만들어보세요! 북마크가 해제되었습니다. + + 북마크 From 0b6239f9ef698c50936bebce6b372f0c5663b220 Mon Sep 17 00:00:00 2001 From: JeonK1 Date: Thu, 30 May 2024 22:45:05 +0900 Subject: [PATCH 07/11] =?UTF-8?q?feat=20:=20SessionDetailScreen=20?= =?UTF-8?q?=EC=97=90=EC=84=9C=20"=EC=84=B8=EC=85=98=EC=86=8C=EA=B0=9C"=20?= =?UTF-8?q?=EB=AC=B8=EA=B5=AC=20=EC=B6=94=EA=B0=80?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../app/feature/session/SessionDetailScreen.kt | 18 +++++++++++++----- .../session/src/main/res/values/strings.xml | 1 + 2 files changed, 14 insertions(+), 5 deletions(-) diff --git a/feature/session/src/main/java/com/droidknights/app/feature/session/SessionDetailScreen.kt b/feature/session/src/main/java/com/droidknights/app/feature/session/SessionDetailScreen.kt index d113fbd2..453c4fe8 100644 --- a/feature/session/src/main/java/com/droidknights/app/feature/session/SessionDetailScreen.kt +++ b/feature/session/src/main/java/com/droidknights/app/feature/session/SessionDetailScreen.kt @@ -252,11 +252,19 @@ private fun SessionDetailSpeaker( @Composable private fun SessionOverview(content: String) { - Text( - text = content, - style = KnightsTheme.typography.titleSmallR140, - color = MaterialTheme.colorScheme.onSecondaryContainer - ) + Column { + Text( + text = stringResource(id = R.string.session_overview_title), + style = KnightsTheme.typography.titleSmallB, + color = MaterialTheme.colorScheme.onSecondaryContainer + ) + Spacer(Modifier.height(4.dp)) + Text( + text = content, + style = KnightsTheme.typography.titleSmallR140, + color = MaterialTheme.colorScheme.onSecondaryContainer + ) + } } @Composable diff --git a/feature/session/src/main/res/values/strings.xml b/feature/session/src/main/res/values/strings.xml index 963032f9..0cd5e861 100644 --- a/feature/session/src/main/res/values/strings.xml +++ b/feature/session/src/main/res/values/strings.xml @@ -12,4 +12,5 @@ 북마크가 해제되었습니다. 북마크 + 세션 소개 From 34024826e3da101de9334a05f4abb70f91fb52dc Mon Sep 17 00:00:00 2001 From: JeonK1 Date: Sun, 2 Jun 2024 14:32:49 +0900 Subject: [PATCH 08/11] =?UTF-8?q?feat=20:=20Session=20=ED=95=98=EB=8B=A8?= =?UTF-8?q?=EC=97=90=20Footer=20=EC=B6=94=EA=B0=80?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../app/feature/session/SessionScreen.kt | 27 ++++++++++++++++++- .../session/src/main/res/values/strings.xml | 1 + 2 files changed, 27 insertions(+), 1 deletion(-) diff --git a/feature/session/src/main/java/com/droidknights/app/feature/session/SessionScreen.kt b/feature/session/src/main/java/com/droidknights/app/feature/session/SessionScreen.kt index befc1e92..270765fe 100644 --- a/feature/session/src/main/java/com/droidknights/app/feature/session/SessionScreen.kt +++ b/feature/session/src/main/java/com/droidknights/app/feature/session/SessionScreen.kt @@ -6,18 +6,24 @@ import androidx.compose.foundation.layout.Column import androidx.compose.foundation.layout.PaddingValues import androidx.compose.foundation.layout.Spacer import androidx.compose.foundation.layout.fillMaxSize +import androidx.compose.foundation.layout.fillMaxWidth import androidx.compose.foundation.layout.height import androidx.compose.foundation.layout.padding import androidx.compose.foundation.layout.systemBarsPadding +import androidx.compose.foundation.layout.wrapContentHeight import androidx.compose.foundation.lazy.LazyColumn import androidx.compose.foundation.lazy.LazyListScope import androidx.compose.foundation.lazy.itemsIndexed import androidx.compose.material3.HorizontalDivider import androidx.compose.material3.MaterialTheme +import androidx.compose.material3.Text import androidx.compose.runtime.Composable import androidx.compose.runtime.LaunchedEffect import androidx.compose.runtime.getValue import androidx.compose.ui.Modifier +import androidx.compose.ui.graphics.Color +import androidx.compose.ui.res.stringResource +import androidx.compose.ui.text.style.TextAlign import androidx.compose.ui.unit.Dp import androidx.compose.ui.unit.dp import androidx.hilt.navigation.compose.hiltViewModel @@ -91,6 +97,7 @@ private fun SessionContent( room = group.room, items = group.sessions, topPadding = topPadding, + isLastGroup = index == sessionState.groups.size - 1, onItemClick = onSessionClick, ) } @@ -98,12 +105,13 @@ private fun SessionContent( } private val SessionTopSpace = 16.dp -private val SessionGroupSpace = 84.dp +private val SessionGroupSpace = 100.dp private fun LazyListScope.sessionItems( room: Room, items: PersistentList, topPadding: Dp, + isLastGroup: Boolean, onItemClick: (Session) -> Unit, ) { itemsIndexed(items) { index, item -> @@ -114,6 +122,9 @@ private fun LazyListScope.sessionItems( topPadding = topPadding, onItemClick = onItemClick ) + if (isLastGroup && index == items.size - 1) { + DroidKnightsFooter() + } } } @@ -152,3 +163,17 @@ private fun RoomTitle( Spacer(modifier = Modifier.height(32.dp)) } } + +@Composable +private fun DroidKnightsFooter() { + Text( + modifier = Modifier + .fillMaxWidth() + .wrapContentHeight() + .padding(top = 56.dp, bottom = 80.dp), + text = stringResource(id = R.string.footer_text), + style = KnightsTheme.typography.labelMediumR, + color = Color.LightGray, + textAlign = TextAlign.Center + ) +} diff --git a/feature/session/src/main/res/values/strings.xml b/feature/session/src/main/res/values/strings.xml index 0cd5e861..e6338fc8 100644 --- a/feature/session/src/main/res/values/strings.xml +++ b/feature/session/src/main/res/values/strings.xml @@ -13,4 +13,5 @@ 북마크 세션 소개 + Droid Knights 2024 From e676171ad3fca329943911f003eef20d6837995b Mon Sep 17 00:00:00 2001 From: JeonK1 Date: Sun, 2 Jun 2024 14:55:59 +0900 Subject: [PATCH 09/11] =?UTF-8?q?feat=20:=20BookmarkScreen=20design=20?= =?UTF-8?q?=EC=B5=9C=EC=8B=A0=ED=99=94?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../com/droidknights/app/feature/bookmark/BookmarkScreen.kt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/feature/bookmark/src/main/java/com/droidknights/app/feature/bookmark/BookmarkScreen.kt b/feature/bookmark/src/main/java/com/droidknights/app/feature/bookmark/BookmarkScreen.kt index 5aeaf5f0..fb933af3 100644 --- a/feature/bookmark/src/main/java/com/droidknights/app/feature/bookmark/BookmarkScreen.kt +++ b/feature/bookmark/src/main/java/com/droidknights/app/feature/bookmark/BookmarkScreen.kt @@ -182,7 +182,7 @@ private fun BookmarkTopAppBar( modifier = Modifier .align(Alignment.CenterEnd) .clickable(onClick = onClickEditButton) - .padding(8.dp), + .padding(6.dp), text = if (isEditMode) { stringResource(id = R.string.edit_button_confirm_label) } else { From c76da989fdc26109ffb8137f11d44d36cc6bc4f7 Mon Sep 17 00:00:00 2001 From: JeonK1 Date: Sun, 2 Jun 2024 15:06:28 +0900 Subject: [PATCH 10/11] =?UTF-8?q?feat=20:=20surfaceDim=20=EC=B6=94?= =?UTF-8?q?=EA=B0=80?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../java/com/droidknights/app/core/designsystem/theme/Theme.kt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/core/designsystem/src/main/java/com/droidknights/app/core/designsystem/theme/Theme.kt b/core/designsystem/src/main/java/com/droidknights/app/core/designsystem/theme/Theme.kt index 9fa3be09..05f438cd 100644 --- a/core/designsystem/src/main/java/com/droidknights/app/core/designsystem/theme/Theme.kt +++ b/core/designsystem/src/main/java/com/droidknights/app/core/designsystem/theme/Theme.kt @@ -36,6 +36,7 @@ private val DarkColorScheme = darkColorScheme( onErrorContainer = Red01, surface = Graphite, onSurface = White, + surfaceDim = Black, inverseSurface = Neon05, inverseOnSurface = Black, outline = DarkGray, @@ -63,6 +64,7 @@ private val LightColorScheme = lightColorScheme( onErrorContainer = Red06, surface = PaperGray, onSurface = DuskGray, + surfaceDim = PaleGray, inverseSurface = Yellow05, inverseOnSurface = White, outline = LightGray, From d74dd830e59687a84dbad77de4a7a1352462b6c1 Mon Sep 17 00:00:00 2001 From: JeonK1 Date: Sun, 2 Jun 2024 15:14:24 +0900 Subject: [PATCH 11/11] delete : unused import --- .../com/droidknights/app/feature/session/SessionDetailScreen.kt | 1 - 1 file changed, 1 deletion(-) diff --git a/feature/session/src/main/java/com/droidknights/app/feature/session/SessionDetailScreen.kt b/feature/session/src/main/java/com/droidknights/app/feature/session/SessionDetailScreen.kt index 453c4fe8..8be9685d 100644 --- a/feature/session/src/main/java/com/droidknights/app/feature/session/SessionDetailScreen.kt +++ b/feature/session/src/main/java/com/droidknights/app/feature/session/SessionDetailScreen.kt @@ -30,7 +30,6 @@ import androidx.compose.ui.Alignment import androidx.compose.ui.Modifier import androidx.compose.ui.draw.clip import androidx.compose.ui.platform.LocalContext -import androidx.compose.ui.res.colorResource import androidx.compose.ui.res.painterResource import androidx.compose.ui.res.stringResource import androidx.compose.ui.tooling.preview.Preview