Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Kotlin 2.0으로 Migration #306

Closed
l2hyunwoo opened this issue May 29, 2024 · 3 comments · Fixed by #309
Closed

[Improvement] Kotlin 2.0으로 Migration #306

l2hyunwoo opened this issue May 29, 2024 · 3 comments · Fixed by #309
Assignees
Labels

Comments

@l2hyunwoo
Copy link
Contributor

l2hyunwoo commented May 29, 2024

Kind (Required)

  • Improvement

Overview (Required)

  • 드로이드나이츠 레포지터리 내 코드를 참고하는 팀/개발자분들이 많은 것으로 알고 있어서, 해당 레포지터리에 2.0 버전을 적용한다면 이후에 이 코드를 참고해서 마이그레이션 하는 분들께 도움이 될 수 있을 것 같습니다.
  • 또한 Kotlin 2.0.0을 활용하여 Kotlin이 관장하는 Compose Compiler를 적용하고 MutableStateFlow에 field를 적용하여 Kotlin 2.0에서 사용할 수 있는 문법적 특성을 공유합니다.
  • 안정성이 보장되어있지 않은 업데이트여서 main브랜치가 아닌 별도의 브랜치에 머지하는 것으로 작업하면 좋을 것 같습니다.

Links

@l2hyunwoo
Copy link
Contributor Author

✋🏻

@taehwandev
Copy link
Member

어차피 다음 드나앱에서는 진행하게 될 내용이라 당장 필요한 부분은 아닐것 같아요.

@taehwandev
Copy link
Member

@l2hyunwoo 진행하시면 별도 브랜치로 처리해두겠습니다.
적용 후 동작에 대한 이상한 부분이 있는지 한번 확인하고 공유부탁드려요.

만약 큰 이상이 없다면 메인에 머지하는것도 고려해보겠습니다. cc. @wisemuji @KimReady

l2hyunwoo added a commit to l2hyunwoo/DroidKnightsApp that referenced this issue May 30, 2024
l2hyunwoo added a commit to l2hyunwoo/DroidKnightsApp that referenced this issue May 30, 2024
l2hyunwoo added a commit to l2hyunwoo/DroidKnightsApp that referenced this issue May 30, 2024
l2hyunwoo added a commit to l2hyunwoo/DroidKnightsApp that referenced this issue May 30, 2024
l2hyunwoo added a commit to l2hyunwoo/DroidKnightsApp that referenced this issue May 30, 2024
l2hyunwoo added a commit to l2hyunwoo/DroidKnightsApp that referenced this issue May 30, 2024
l2hyunwoo added a commit to l2hyunwoo/DroidKnightsApp that referenced this issue May 30, 2024
l2hyunwoo added a commit to l2hyunwoo/DroidKnightsApp that referenced this issue May 30, 2024
l2hyunwoo added a commit to l2hyunwoo/DroidKnightsApp that referenced this issue May 30, 2024
taehwandev added a commit that referenced this issue May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants