Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCS live tests can be flaky on blob.patch #267

Closed
github-actions bot opened this issue Aug 21, 2022 · 2 comments
Closed

GCS live tests can be flaky on blob.patch #267

github-actions bot opened this issue Aug 21, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@github-actions
Copy link
Contributor

Workflow failed: tests #580

@github-actions github-actions bot added the bug Something isn't working label Aug 21, 2022
@pjbull
Copy link
Member

pjbull commented Aug 22, 2022

The GCS tests have recently become flaky. We should see if there's some retry setting we can use at the SDK level to avoid this kind of flakiness.

Here's the error:

E           google.api_core.exceptions.ServiceUnavailable: 503 PATCH https://storage.googleapis.com/storage/v1/b/***/o/8pTzjcQttNHsrKFDubuBWw-test_cloudpath_upload_copy-test_upload_from_dir%2Fupload_test_dir%2Fupload_1.txt?generation=1661041260576377&projection=full&prettyPrint=false: We encountered an internal error. Please try again.

For the 2 failing tests, both of the call stacks look like the following and involve the blob.patch call:

cloudpathlib/gs/gspath.py:49: in touch
    self.client._move_file(self, self)
cloudpathlib/gs/gsclient.py:185: in _move_file
    blob.patch()
/opt/hostedtoolcache/Python/3.8.13/x64/lib/python3.8/site-packages/google/cloud/storage/_helpers.py:337: in patch
    api_response = client._patch_resource(
/opt/hostedtoolcache/Python/3.8.13/x64/lib/python3.8/site-packages/google/cloud/storage/client.py:463: in _patch_resource
    return self._connection.api_request(
/opt/hostedtoolcache/Python/3.8.13/x64/lib/python3.8/site-packages/google/cloud/storage/_http.py:73: in api_request
    return call()

@pjbull pjbull changed the title Failed build on master branch (tests #580) GCS live tests can be flaky on blob.patch Sep 7, 2022
@pjbull
Copy link
Member

pjbull commented Dec 19, 2022

Haven't seen in a while. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant