Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Incorrect file count after cloning menus with playable items #144

Open
rahaaatul opened this issue Feb 17, 2023 · 3 comments
Open
Labels
bug Something isn't working

Comments

@rahaaatul
Copy link

rahaaatul commented Feb 17, 2023

Describe the bug
AutoWidget isn't displaying the cloned shortcuts, only next page. (https://jewbmx.github.io//).

To Reproduce
Steps to reproduce the behavior:

  1. Go to any source (eg. TMDB Helper) and find some shortcut to clone...
  2. Click on Add to AutoWidget Group
  3. Click on "Clone as Shortcut Group".
  4. Go to AutoWidget > My Groups
  5. See error.

Expected behavior
Should display all the contents.

Screenshots

AutoWidget.-.Scrubs.mp4

Details:

  • What version of Kodi? 19.5
  • What skin is being used? Arctic Zephyr Reloaded
  • What device? (PC, Smartphone, Fire TV, Nvidia Shield, etc...) PC
  • What platform? (Android, iOS, Windows, OS X, Linux, etc...) Windows
@rahaaatul rahaaatul added the bug Something isn't working label Feb 17, 2023
@rahaaatul rahaaatul changed the title [Bug] AutoWidget not cloning shortcuts from Scrubs v2 [Bug] AutoWidget not cloning shortcuts Feb 17, 2023
@rahaaatul
Copy link
Author

Weird, it worked all of a sudden, and broke again.

@drinfernoo
Copy link
Owner

This is not what shortcut groups are meant for. In fact, when making shortcuts (or during a "clone"), playable items are skipped and/or not allowed to be made into shortcuts.

This is actually intended behavior, and the recommended way to do what you're trying to do is to add that path to a widget group, and then use it as a static path.

You have, however, highlighted a small bug, in that it should not include skipped items in the count that gets shown in the dialog.

"AutoWidget", utils.get_string(30104).format(len(files), group_def["label"])

Here, the len(files) should be changed to a variable that is incremented during the loop, but after the continue, likely on L296.

@drinfernoo drinfernoo changed the title [Bug] AutoWidget not cloning shortcuts [Bug] Incorrect file count after cloning menus with playable items Feb 18, 2023
@rahaaatul
Copy link
Author

rahaaatul commented Feb 18, 2023

Thank you, I just did that and it works.
But I want to include multiple sources into one like Movies Trending This Week and TV Shows Trending This Week in a label called Trending This Week and sort them by ratings.
So I tried the merged option and selected both source but for one it says loading content but never loads it and other loads.

But before when I used the clone as shortcuts, it worked perfectly. I don't know why it stopped working suddenly, only shows next page.

Can you add an option to not to skip playable items and allow those items?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants