Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ion-view pushes to stack #1667

Closed
mlynch opened this issue Jun 24, 2014 · 3 comments
Closed

ion-view pushes to stack #1667

mlynch opened this issue Jun 24, 2014 · 3 comments

Comments

@mlynch
Copy link
Contributor

mlynch commented Jun 24, 2014

When using <ion-view> in certain places (like a Modal), it can unexpectedly push a state to the stack and then show a back button incorrectly when the modal is closed.

Can we add a way to say this view will not push to the stack, or provide more clear ways of using the ion-view tags in modals and other non-navigational UIs?

@ajoslin
Copy link
Contributor

ajoslin commented Jul 7, 2014

We could check if there's a parent modal when using ion-view and do nothing if so.

We could also possibly make this slightly more generic. Looking into it.

@ajoslin ajoslin closed this as completed in b7f45e7 Jul 7, 2014
@travisdahl
Copy link

Don't mean to go off topic, but is there a way to manually add to the history stack? I have a case where I am changing the urls manually from slide to slide (without triggering a state change), but would still like to add to the stack for back button purposes after I leave the slides.

@ladmerc
Copy link

ladmerc commented Jun 9, 2016

@travisdahl Did you find a way to push to history stack? I need a similar feature

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants