Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo error #1521

Closed
wants to merge 1 commit into from
Closed

fix typo error #1521

wants to merge 1 commit into from

Conversation

roychoo
Copy link

@roychoo roychoo commented May 29, 2014

there is typo error that is causing ion-item not able to work with anchor.

Regards
Roy

@roychoo
Copy link
Author

roychoo commented May 29, 2014

hmmm one more thing,

i dun really understand

$scope.$target = $attrs.href || '_self';

am i missing something?
why do we set target to the value of href?

@perrygovier
Copy link
Contributor

Hey Roychoo, good catch. That was added as part of an earlier PR and we completely missed that. Would you like to change $attrs.href to $attrs.target?

@ajoslin Any reason not to add this?

@roychoo roychoo assigned perrygovier and ajoslin and unassigned perrygovier May 29, 2014
@roychoo
Copy link
Author

roychoo commented Jun 3, 2014

@perrygovier sure. will add this later. :)

@ajoslin
Copy link
Contributor

ajoslin commented Jun 4, 2014

That's why unit tests rock! Fixed.

@ajoslin ajoslin closed this in f5f5851 Jun 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: reply the issue needs a response from the user
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants