-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android 4.2.2 physical device error #1377
Comments
I'm always amazed when people open issues like this and provide 0 code and 0 context and expect their issue to be fixed....... |
I do not expect anything... so i will close the issue... I guess i am the only one having this issue. |
I noticed this testing a few days ago, probably worth checking out at some point, although it didn't seem to break anything. It was in requestAnimationFrame on the initial load if I recall. |
Yeah, i noticed it would throw this error when you change views... I am using android-tools -> monitor. running on Samsung Galaxy S cyanogen 10.1.3.1-eepicmtd, android 4.2.2 |
This error is coming from the domUtil around line 6012 (as of beta5) in ionic.bundle.js
It appears that some versions of Android will not allow the ionic.DomUtil#getTextBounds method to use range.selectNodeContents(textNode); on the elements in the nav bar. This method was created back in November 2013 commit, so the issue has likely existed for some time, but the fact that it is only on certain Android versions is why it has not been seen for everyone. I don't believe it is affecting performance having done few experiments testing without it. Just to track from here and the forum. The Android versions it has been seen on are 4.2.2, 4.3.0 and as far as I can tell the nav bar just needs to have any buttons or title to get the error. |
softBarbarian Thanks for reporting this. I saw the same error in the log and I was going to report it. |
I still have the same bug with the last beta 6 release. Do you know when this bug will be fixed? |
@tplessis it doesn't seem to be breaking anything at the moment so it's a pretty low priority, feel free to look into it and submit a PR if you would like. |
Hello, again currently we collect remote error logs, this error is filling up our logs! I think I am going to have to hardcode some logic to our logger to ignore it until this is fixed. |
This seems to break title alignment on the cases where the error pops up. The |
Tested. All is good! |
When I run my app on physical device I get following error:
Web Console: Uncaught TypeError: Cannot read property 'width' of null at file:///android_asset/www/bower_components/ionic/release/js/ionic.js:5679
The text was updated successfully, but these errors were encountered: