Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pressing a single tab button highlights the whole tab menu #1317

Closed
luiscruz opened this issue May 9, 2014 · 12 comments
Closed

Pressing a single tab button highlights the whole tab menu #1317

luiscruz opened this issue May 9, 2014 · 12 comments

Comments

@luiscruz
Copy link

luiscruz commented May 9, 2014

Hi,

I am bothering you again with the tabs. I believe the title clearly describes the issue, but if you need more details I am willing to give you.

I've reproduced it in the following code pen:
http://codepen.io/luiscruz/pen/Keqdm

Thanks, Luis

@ajoslin
Copy link
Contributor

ajoslin commented May 9, 2014

Hi @luiscruz!

I see what you are saying ... @adamdbradley what do you think? Basically, there's a .item with a.tab-items inside, and the click is activating the parent .item.

@luiscruz
Copy link
Author

Any news regarding this @ajoslin @adamdbradley ?

@adamdbradley
Copy link
Contributor

@ajoslin did this one fix this issue? 3c15b118ca74

@ajoslin
Copy link
Contributor

ajoslin commented May 13, 2014

Yes.

@ajoslin ajoslin closed this as completed May 13, 2014
@ajoslin ajoslin reopened this May 13, 2014
@ajoslin
Copy link
Contributor

ajoslin commented May 13, 2014

It adds the activated class properly now, but the css for active tab items isn't right. Fixing.

@ajoslin ajoslin self-assigned this May 13, 2014
@ajoslin ajoslin removed the ready label May 13, 2014
@luiscruz
Copy link
Author

I've also checked 3c15b11 and it fixes the problem with the scroll. Thanks

@luiscruz
Copy link
Author

The whole tab seems to be activated even with 3c15b11 ..
http://codepen.io/luiscruz/pen/Keqdm

@ajoslin
Copy link
Contributor

ajoslin commented May 13, 2014

Be sure to use the nightly build. Also, 1b1c234 won't be built for about 30 more minutes (it takes some time to build & propagate).

@luiscruz
Copy link
Author

Sorry I meant to say 1b1c234
I've downloaded the code from commit 1b1c234 and built only the scss and uploaded the result css to the cloud.
Then changed the stylesheet in my code pen:
http://codepen.io/luiscruz/pen/Keqdm

The problem still persists, thanks!

@ajoslin
Copy link
Contributor

ajoslin commented May 13, 2014

Try the nightly builds, they're up now. You had to update the JS too.

    <link href="http://code.ionicframework.com/nightly/css/ionic.css" rel="stylesheet">
    <script src="http://code.ionicframework.com/nightly/js/ionic.bundle.js">

@luiscruz
Copy link
Author

Thanks, it is perfect! :)

@ionitron-bot
Copy link

ionitron-bot bot commented Sep 6, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants