Skip to content

Commit

Permalink
feat(modal): bg only for inset modals
Browse files Browse the repository at this point in the history
  • Loading branch information
@adamdbradley
adamdbradley committed Dec 31, 2014
1 parent cb77f29 commit 5de1c12
Showing 1 changed file with 9 additions and 6 deletions.
15 changes: 9 additions & 6 deletions scss/_modal.scss
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,18 +6,12 @@
*/

.modal-backdrop {
@include transition(background-color 300ms ease-in-out);
position: fixed;
top: 0;
left: 0;
z-index: $z-index-modal;
width: 100%;
height: 100%;
background-color: $modal-backdrop-bg-inactive;

&.active {
background-color: $modal-backdrop-bg-active;
}
}

.modal {
Expand Down Expand Up @@ -74,6 +68,15 @@
top: $bar-height + $bar-subheader-height + $tabs-height;
}
}

.modal-backdrop {
@include transition(background-color 300ms ease-in-out);
background-color: $modal-backdrop-bg-inactive;

&.active {
background-color: $modal-backdrop-bg-active;
}
}
}

// disable clicks on all but the modal
Expand Down

3 comments on commit 5de1c12

@vladipus
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? I mean, really, the backdrop should always be shown, since no matter what the focus of the user is changed to the modal, isn't it?

@offbye
Copy link

@offbye offbye commented on 5de1c12 Jun 9, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how to show backdrop now ?

@vladipus
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've go the following solution from the dev:
#3875 (comment)

Please sign in to comment.