Fix CMake to be included via CPM #34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Main problem was that the header was not found by the containing
proect. Took also the liberty to cleanup the CMakeLists.txt
Now including the project is as simple as:
```CMake
CPMAddPackage("gh:/dridk/QJsonModel#master")
target_link_libraries(my_epic_app Qt6::Core Qt6::Widgets Qt6::PrintSupport Qt6::Svg Qt6::Xml QJsonModelStatic)
```
Then in your C++ file:
```C++
auto model = new QJsonModel();
model->loadJson(str.toUtf8());
treeView->setModel(model);
```
It seems most of the code was not needed, and reduced the build script even more. The trigger? It worked on my Fedora system, but not on my Debian. Removed most of the C related stuff, removed redundant declarations. Include path fixed.
On MSVC CMake cannot make foo.dll, and foo.lib. If you try to do this, you get: ``` [cmake] ninja: error: build.ninja:2527: multiple rules generate _deps/qjsonmodel-build/QJsonModel.lib ``` To overcome this, the static target will have its own output name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main problem was that the header was not found by the containing proect. Took also the liberty to cleanup the CMakeLists.txt. I also fixed compilation under MSVC (only build system problems, code compiles perfectly).
Now including the project is as simple as:
Then in your C++ file:
I might need to review the commit message, as its kinda.. not ideal :) and also squash the commits - if the fixes are good for you.