Visual peeve: Lorekeeper Annals

[orkaboy]

It's quite neat that the Tales of the Legion appear procedurally when filling in names in the Book (I haven't seen what happens when you fill out all of them yet, so I haven't tested if the ability to add more tales after that work). One minor thing though:

When a name is added, this opens up the next text box on the list (possibly opening a new Tale entry). However, there's no way to clear an entry once it's been written. You can remove that name from the list, but what has been unlocked remains unlocked (includign the empty fields that say "Name").

This is a minor gripe, and trying to fix it may introduce weird behavior (ie, what happens if you try to remove a name in the middle of the Annals? What is supposed to happen?), so I'll leave it up to you if you want to do something about it or leave it like it is now.

[drewg13]

This is something I always meant to address, but I spent quite a bit of time getting it to work as much as it does. Something to come back to and improve. Perhaps a manual delete icon? Might work.

[orkaboy]

I dug through the code but didn't understand all of it (not familiar with the frameworks used), but I figured that the sheet lists all object keys. Maybe it's possible to remove empty string keys in a step somewhere (unless the key is something else than the text in this case).

[drewg13]

I haven't gone back to look yet, but that's an astute observation. Foundry database updates are diffed, so deleting keys from objects requires some unintuitive magic syntax to differentiate "missing because unchanged" from "missing because removed". Not hard, once you know, though.

[drewg13]

Thinking about this, my impression now and at the time was that there isn't much call to ever remove a name from the list during actual gameplay. They're going on the list because they're dead. The only time it makes sense to be removing a name is if you're just playing around with the sheet. I'm going to shelve this for now and maybe look into it again in the near future when I'm making major updates for V10.

[orkaboy]

Thinking about this, my impression now and at the time was that there isn't much call to ever remove a name from the list during actual gameplay. They're going on the list because they're dead. The only time it makes sense to be removing a name is if you're just playing around with the sheet. I'm going to shelve this for now and maybe look into it again in the near future when I'm making major updates for V10.

Sounds fair. It was a relatively minor issue anyways. My main issue wouldn't be people being stricken from the list because they are not dead anymore, but rather entries added by mistake. But yeah, no biggie.