Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

split validation limitations #7

Open
Lydecker opened this issue Jul 7, 2018 · 7 comments
Open

split validation limitations #7

Lydecker opened this issue Jul 7, 2018 · 7 comments

Comments

@Lydecker
Copy link

Lydecker commented Jul 7, 2018

Great script,

but quick note - this doesn't cater for top level domains with two periods in:

eg: example.co.uk

due to the split validation
@drewfurgiuele
Copy link
Owner

Thanks @Lydecker . I'll take a look and see what I can do. Sorry for the late follow-up,

@Lydecker
Copy link
Author

Lydecker commented Sep 4, 2018

Thanks - much appreciated.

@BiatuAutMiahn
Copy link

It's the if statement after line 87

@BiatuAutMiahn
Copy link

was this fixed? I had to comment out this check to get my subdomains to update

@Lydecker
Copy link
Author

it was never fixed :(

@BiatuAutMiahn
Copy link

I'll fork and patch soon since it is a simple fix

@drewfurgiuele
Copy link
Owner

Sorry all! Changed jobs in June and now just playing catch-up. @BiatuAutMiahn if you've got a fix go ahead and submit a PR. Thanks.

@KAsp3rd KAsp3rd mentioned this issue May 20, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@drewfurgiuele @BiatuAutMiahn @Lydecker