Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Dockerfile #56

Open
OlegLazaryev opened this issue Dec 3, 2018 · 1 comment
Open

Improve Dockerfile #56

OlegLazaryev opened this issue Dec 3, 2018 · 1 comment
Assignees

Comments

@OlegLazaryev
Copy link
Contributor

OlegLazaryev commented Dec 3, 2018

Together with @vadimt-spg discussed how to tune current version of Dockerfile.
See our thoughts below.

As first step we can split current image into two. One is dreamfactory-base and will contain all the dependencies. This adds two benefits:

  • potentially faster build time for end customers;
  • fault tolerant since the dependencies are installed once on build time by DockerHub. This prevents customers from facing version update issues like we saw recently with V8. Meaning that end customers won't install the dependencies. Instead they will simply pull the base image;
  • @vadimt-spg should also research how to squash the layers to make the image more efficient.

Another improvement could be to reuse installation script for Ubuntu (after it's ready) instead of manually installing the dependencies in Dockerfile. This brings much more consistency since we will have a single point of failure. Also any change in dependencies will happen in single file instead of modifying both Install Script and Dockerfile.

@OlegLazaryev
Copy link
Contributor Author

@wjgilmore please let us know what you think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants