Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(facade): add formula facade #4348

Merged
merged 2 commits into from
Jan 7, 2025
Merged

feat(facade): add formula facade #4348

merged 2 commits into from
Jan 7, 2025

Conversation

Gggpound
Copy link
Contributor

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Dec 21, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Dec 21, 2024

Playwright test results

passed  21 passed

Details

stats  21 tests across 10 suites
duration  4 minutes, 46 seconds
commit  5d62fb8
info  For more information, see full report

Copy link

codecov bot commented Dec 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 33.37%. Comparing base (862e70b) to head (5d62fb8).
Report is 64 commits behind head on dev.

Files with missing lines Patch % Lines
packages/engine-formula/src/facade/f-formula.ts 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4348      +/-   ##
==========================================
- Coverage   33.37%   33.37%   -0.01%     
==========================================
  Files        2517     2517              
  Lines      129886   129891       +5     
  Branches    29011    29012       +1     
==========================================
  Hits        43349    43349              
- Misses      86537    86542       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Dushusir Dushusir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests would be better

@weird94 weird94 merged commit de097d8 into dev Jan 7, 2025
9 checks passed
@weird94 weird94 deleted the feat-feacade-1221 branch January 7, 2025 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants