Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cal page size in modern mode #4128

Merged
merged 1 commit into from
Nov 23, 2024
Merged

fix: cal page size in modern mode #4128

merged 1 commit into from
Nov 23, 2024

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented Nov 22, 2024

close https://github.com/dream-num/univer-pro/issues/3434
close https://github.com/dream-num/univer-pro/issues/2927

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Nov 22, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Nov 22, 2024

Playwright test results

passed  20 passed

Details

stats  20 tests across 9 suites
duration  4 minutes, 48 seconds
commit  41342be
info  For more information, see full report

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.

Project coverage is 33.75%. Comparing base (2c3efff) to head (41342be).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
...ollers/render-controllers/doc.render-controller.ts 0.00% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4128      +/-   ##
==========================================
- Coverage   33.76%   33.75%   -0.01%     
==========================================
  Files        2457     2457              
  Lines      127783   127796      +13     
  Branches    28607    28607              
==========================================
  Hits        43141    43141              
- Misses      84642    84655      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@Jocs Jocs marked this pull request as ready for review November 23, 2024 02:21
@Jocs Jocs requested a review from jikkai as a code owner November 23, 2024 02:21
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Nov 23, 2024
@oumomomo oumomomo added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Nov 23, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Nov 23, 2024
@Jocs Jocs merged commit a58350b into dev Nov 23, 2024
14 checks passed
@Jocs Jocs deleted the fix/page-size branch November 23, 2024 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants